Skip to content

Conversation

@lumtis
Copy link
Contributor

@lumtis lumtis commented Sep 22, 2022

Add different features to improve chain list command

  • Add Phase information in the table. This gives the current phase the chain launch is into:
    • Coordinating: launch not triggered, waiting for requests
    • Launching: launch triggered
    • Launched: genesis time reached
ignite n chain list
Launch Id 	Chain Id 	Source 					Phase
10 		planet-1 	https://github.com/lubtd/planet 	coordinating
9 		planet-1 	https://github.com/lubtd/planet 	coordinating
8 		planet-1 	https://github.com/lubtd/planet 	coordinating
7 		planet-1 	https://github.com/lubtd/planet 	launching
6 		planet-1 	https://github.com/lubtd/planet 	launched
5 		spn-11 		https://github.com/tendermint/spn.git 	coordinating
4 		spn-11 		https://github.com/tendermint/spn.git 	coordinating
3 		mars-1 		https://github.com/lubtd/planet.git 	coordinating
2 		spn-10 		https://github.com/tendermint/spn.git 	coordinating
1 		spn-1 		https://github.com/tendermint/spn 	coordinating
  • Hide advanced information: Campaign ID, Network type and rewards. Add flag --advanced to show those information
ignite n chain list --advanced
Launch Id 	Chain Id 	Source 					Phase 		Campaign Id 	Network Reward
28 		spn-11 		https://github.com/tendermint/spn.git 	coordinating 	no campaign 	testnet -
27 		spn-11 		https://github.com/tendermint/spn.git 	coordinating 	no campaign 	testnet -
26 		mars-1 		https://github.com/lubtd/planet.git 	coordinating 	no campaign 	testnet -
25 		spn-10 		https://github.com/tendermint/spn.git 	coordinating 	no campaign 	testnet -
24 		planet-1 	https://github.com/lubtd/planet 	coordinating 	no campaign 	testnet -
23 		planet-1 	https://github.com/lubtd/planet 	coordinating 	no campaign 	testnet -
22 		planet-1 	https://github.com/lubtd/planet 	coordinating 	no campaign 	testnet -
21 		planet-1 	https://github.com/lubtd/planet 	coordinating 	no campaign 	testnet -
20 		planet-1 	https://github.com/lubtd/planet 	coordinating 	no campaign 	testnet -
19 		spn-1 		https://github.com/tendermint/spn 	coordinating 	no campaign 	testnet -
  • Limit the number of result per page, this can be customized by --limit and add --page flag to choose the page of results depending on the limit
ignite n chain list --limit 10 --page 2
Launch Id 	Chain Id 	Source 					Phase
28 		spn-11 		https://github.com/tendermint/spn.git 	coordinating
27 		spn-11 		https://github.com/tendermint/spn.git 	coordinating
26 		mars-1 		https://github.com/lubtd/planet.git 	coordinating
25 		spn-10 		https://github.com/tendermint/spn.git 	coordinating
24 		planet-1 	https://github.com/lubtd/planet 	coordinating
23 		planet-1 	https://github.com/lubtd/planet 	coordinating
22 		planet-1 	https://github.com/lubtd/planet 	coordinating
21 		planet-1 	https://github.com/lubtd/planet 	coordinating

@lumtis lumtis added the skip-changelog Don't check changelog for new entries label Sep 22, 2022
@lumtis lumtis self-assigned this Sep 22, 2022
@tbruyelle
Copy link
Contributor

@lubtd flagPage usually starts at 1 not 0, this is the case in the node command of CLI, but also in the cosmos-sdk commands that needs pagination. Maybe you should do the same to avoid confusion.

@lumtis
Copy link
Contributor Author

lumtis commented Sep 23, 2022

@lubtd flagPage usually starts at 1 not 0, this is the case in the node command of CLI, but also in the cosmos-sdk commands that needs pagination. Maybe you should do the same to avoid confusion.

Thanks, added

Copy link
Contributor

@tbruyelle tbruyelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@lumtis lumtis merged commit 857858a into develop Sep 23, 2022
@lumtis lumtis deleted the refactor/network-chain-list branch September 23, 2022 16:02
Jchicode pushed a commit to Jchicode/cli that referenced this pull request Aug 9, 2023
* advanced flag

* pagination

* format

* import

* chain list

Co-authored-by: Alex Johnson <alex@shmeeload.xyz>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip-changelog Don't check changelog for new entries

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants