test: TxService.Broadcast() #2833
Merged
+399
−102
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The change introduces a new interface to mock the call to tx.Sign(). I found more interesting to assert the call to that function rather than trying to assert its behavior in term of code, which is basically testing the cosmos-sdk, and we don't want to do that. By adding the test I found a bug in the error comparison that I introduced previously with the rpcWrapper, so I fixed it.
tbruyelle
requested review from
aljo242,
fadeev,
ilgooz,
jeronimoalbi and
lumtis
as code owners
Jchicode
pushed a commit
to Jchicode/cli
that referenced
this pull request
Aug 9, 2023
The change introduces a new interface to mock the call to tx.Sign(). I found more interesting to assert the call to that function rather than trying to assert its behavior in term of code, which is basically testing the cosmos-sdk, and we don't want to do that. By adding the test I found a bug in the error comparison that I introduced previously with the rpcWrapper, so I fixed it. Co-authored-by: Alex Johnson <alex@shmeeload.xyz>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The change introduces a new interface to mock the call to tx.Sign(). I found more interesting to assert the call to that function rather than trying to assert its behavior in term of code, which is basically testing the cosmos-sdk, and we don't want to do that.
By adding the test I found a bug in the error comparison that I introduced previously with the rpcWrapper, so I fixed it.
The change also adds a bunch of expect helpers function to reduce the number of lines in the setup functions, which improves readability.