fix: change vuex generation to use a default TS client path #2831
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With the latest changes it is possible to only define a config path for the Vuex generation leaving the TS client path empty. This changeset makes sure that in that case there is a default value for it.
jeronimoalbi
requested review from
aljo242,
fadeev,
ilgooz,
lumtis and
tbruyelle
as code owners
jeronimoalbi
changed the title
aljo242
reviewed
Sep 16, 2022
tbruyelle
reviewed
Sep 17, 2022
added 6 commits
September 19, 2022 11:14
This change keeps the semantics of the `Generate` function targets and allows overriding the configured or default output path when generating the typescript client.
The TS client folder can be a name in which case it should be considered a relative path, which is the case for the default directory name "ts-client".
tbruyelle
approved these changes
Sep 20, 2022
Jchicode
pushed a commit
to Jchicode/cli
that referenced
this pull request
Aug 9, 2023
) * fix: change TS client generation to use a default config generating vuex With the latest changes it is possible to only define a config path for the Vuex generation leaving the TS client path empty. This changeset makes sure that in that case there is a default value for it. * chore: update changelog * chore: check that package.json exists before trying to update it * chore: clean the configured TS client path * refactor: add output path support ts-client generation cmd * refactor: change `GenerateTSClient` to accept the output path This change keeps the semantics of the `Generate` function targets and allows overriding the configured or default output path when generating the typescript client. * fix: change vuex dependency update to handle non absolute paths The TS client folder can be a name in which case it should be considered a relative path, which is the case for the default directory name "ts-client".
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2829