docs(guide/hello): revert grpc registration removal #2819
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix #2817 There's 2 reasons why the change should be reverted: - the version that does the registration automatically is not released yet (0.24) - the hello tutorial requires the use of cli 0.22, where the registration is always manual. What could be changed in the 0.24 documentation: - remove the 0.22 requirement (latest could be used w/o any problem I think) - remove the manual grpc registration.
|
Visit the preview URL for this PR (updated for commit dae8536): https://ignite-go-docs--pr2819-docs-fix-grpc-regist-nkdr8idj.web.app (expires Fri, 16 Sep 2022 11:08:19 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 |
jeronimoalbi
approved these changes
Sep 9, 2022
aljo242
approved these changes
Sep 9, 2022
Jchicode
pushed a commit
to Jchicode/cli
that referenced
this pull request
Aug 9, 2023
Fix ignite#2817 There's 2 reasons why the change should be reverted: - the version that does the registration automatically is not released yet (0.24) - the hello tutorial requires the use of cli 0.22, where the registration is always manual. What could be changed in the 0.24 documentation: - remove the 0.22 requirement (latest could be used w/o any problem I think) - remove the manual grpc registration.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #2817
Revert part of commit 7c836df
There's 2 reasons why this change should be reverted:
What could be changed in the 0.24 documentation: