refactor(network): upgrade spn
#2816
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lumtis
requested review from
aljo242,
fadeev,
ilgooz,
jeronimoalbi and
tbruyelle
as code owners
|
Changelog? |
I will continue to work on this PR for some of the other changes so it can remain open for review without me being blocked. Btw I don't think we need to enforce changelog for each PR, sometimes it's not relevant and the changelog file shouldn't be too much extensive |
…nto network/launch-time
lumtis
changed the title
network): upgrade spn and replace remaining-time by launch-timenetwork): upgrade spn
tbruyelle
reviewed
Sep 8, 2022
tbruyelle
reviewed
Sep 12, 2022
tbruyelle
previously approved these changes
Sep 12, 2022
Co-authored-by: Thomas Bruyelle <thomas.bruyelle@gmail.com>
tbruyelle
approved these changes
Sep 12, 2022
Jchicode
pushed a commit
to Jchicode/cli
that referenced
this pull request
Aug 9, 2023
* update go mod * clock package * refactor network * new cmd * last changes * typoe * import * fix unit test * fix test 2 * Upgrade for send request * publish: add balance * new logic for adding accounts * format * change switch * changelog * Update ignite/cmd/network_chain_join.go Co-authored-by: Thomas Bruyelle <thomas.bruyelle@gmail.com> Co-authored-by: Alex Johnson <alex@shmeeload.xyz> Co-authored-by: Thomas Bruyelle <thomas.bruyelle@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #2812
remaining-timeis replaced by absolutelaunch-timeMsgSendRequest--account-balanceflag inpublishfor the coordinator to fix genesis account balancejoinif it existsTesting
SPN:
Ignite