fix(template): use slashes for key separators #2815
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fadeev
requested review from
aljo242,
ilgooz,
jeronimoalbi,
lumtis and
tbruyelle
as code owners
fadeev
changed the title
|
Visit the preview URL for this PR (updated for commit 9d91afc): https://ignite-go-docs--pr2815-fadeev-key-sep-k02h8rxr.web.app (expires Wed, 14 Sep 2022 14:49:31 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 |
jeronimoalbi
approved these changes
Sep 7, 2022
We used dashes initially and switched to slashes which is more intuitive for a path and used in SDK modules. I didn't know some dashes remained |
lumtis
approved these changes
Sep 7, 2022
aljo242
approved these changes
Sep 7, 2022
Jchicode
pushed a commit
to Jchicode/cli
that referenced
this pull request
Aug 9, 2023
* fix: use slashes for key separators * docs: prefixes Co-authored-by: Jerónimo Albi <jeronimo.albi@tendermint.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed we're using both dashes
-and slashes/for key index separators. Might as well stick to one convention.