fix(network): Gitpod networking issue
#2713
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ilgooz
reviewed
Aug 8, 2022
|
I think I see the error. We set a temporary home to test the chain with the requests. Then this home is used by |
lumtis
requested review from
aljo242,
fadeev,
jeronimoalbi and
tbruyelle
as code owners
ilgooz
approved these changes
Aug 9, 2022
Jchicode
pushed a commit
to Jchicode/cli
that referenced
this pull request
Aug 9, 2023
* remove address check * set back public address check * change init logic * import
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We initialized the chain in a temporary directory so we could have a genesis to check the existing accounts without erasing the current gentx.
At the end, I think we don't need this if we don't provide a gentx from a custom path. If we use the default gentx, it means we use the one from the chain home, so the chain is already initialized.
We initialize the chain in the home if a custom gentx is used to check the accounts, when a custom gentx is used the node ID will be parsed in the gentx itself