fix(template): missing call to RegisterMsgServer #2636
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix #1960 From the cosmos-docs [1], this method `RegisterMsgServer` should be called inside the module `RegisterServices`. The fact that we manage to run a chain w/o that call is still a mistery for now. [1] https://docs.cosmos.network/main/building-modules/messages-and-queries.html#msg-services
tbruyelle
requested review from
fadeev,
ilgooz,
ivanovpetr,
jeronimoalbi and
lumtis
as code owners
jeronimoalbi
approved these changes
Jul 19, 2022
tbruyelle
changed the title
lumtis
approved these changes
Jul 21, 2022
Because sending a tx that triggers a state transition is done by sending a request to the It may change with |
|
@tbruyelle why |
During our last weekly meeting, I understood that @ilgooz wants to freeze the merges until the v0.22.3 release. Maybe this one can be merged though. |
Closed
Jchicode
pushed a commit
to Jchicode/cli
that referenced
this pull request
Aug 9, 2023
Fix ignite#1960 From the cosmos-docs [1], this method `RegisterMsgServer` should be called inside the module `RegisterServices`. The fact that we manage to run a chain w/o that call is still a mistery for now. [1] https://docs.cosmos.network/main/building-modules/messages-and-queries.html#msg-services Co-authored-by: Lucas Btd <lucas.bertrand.22@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1960
From the cosmos-docs [1], this method
RegisterMsgServershould becalled inside the module
RegisterServices. The fact that we manage torun a chain w/o that call is still a mistery for me.
[1] https://docs.cosmos.network/main/building-modules/messages-and-queries.html#msg-services