feat: Client config typing #2569
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clockworkgr
requested review from
Pantani,
fadeev,
ilgooz,
ivanovpetr and
lumtis
as code owners
jeronimoalbi
reviewed
Aug 3, 2022
jeronimoalbi
reviewed
Aug 3, 2022
jeronimoalbi
approved these changes
Sep 2, 2022
ilgooz
added a commit
that referenced
this pull request
Sep 12, 2022
…2142) (#2143) * feat(frontend): ts-client + pinia (#2142) * Update index.ts.tpl * Update index.ts.tpl * Update package.json.tpl * Update index.ts.tpl * Update package.json.tpl * Update generate_javascript.go * Create index.ts.tpl * Create module.ts.tpl * Create pinia.ts.tpl * Create idnex.ts.tpl * Rename idnex.ts.tpl to index.ts.tpl * Create package.json.tpl * Delete starport/pkg/cosmosgen/templates/vuex directory * Delete starport/pkg/cosmosgen/templates/js directory * Update cosmosgen.go * Update generate_javascript.go * Update template.go * Update generate.go * Update generate.go * Update scaffolder.go * Rename generate_vuex.go to generate_sdk.go * Update config.go * Update generate_javascript.go * Update build.go * Update generate_sdk.go * Update generate_javascript.go * Update generate_javascript.go * 🏗 * adjusted pinia path * 🏗 * n * n * Update starport/pkg/cosmosgen/templates/root/index.ts.tpl Co-authored-by: Alex Megalokonomos <alex@clockwork.gr> * n * plugins * refactored * adjusted ts templates * mod tidy * better syntax * bump @ignt/plugins * tpl header * string formatting * adjusted test out dir * adjusted integration test * adjusted integration test * minors * Update docs/cli/index.md Co-authored-by: Barrie Byron <barriebyron@gmail.com> * Update ignite/cmd/generate_typescript_client.go Co-authored-by: Barrie Byron <barriebyron@gmail.com> * Update docs/kb/frontend.md Co-authored-by: Barrie Byron <barriebyron@gmail.com> * Update build.go * expand on the web app template * grammar fixes for the articles * mono repo URL is changed * add missing article for grammar fix * grammar fix and add more scope to the web app template * feat: Client config typing (#2569) * feat: Client config typing * fix: remove console * wip * wip * fix: remove accidentally committed files * fixed: type issues/code duplication * fix: use new @starport/vuex getter * fix: correct export * fix: changed generate typescript and vuex to match latest changes * fix: change output dir for typescript root templates * fix: remove "module" suffix from typescript module paths It seems that the module folder was replaced by the `module.ts` file during module generation. * fix: replace deprecated `strings.Title()` by a caser * fix: remove unused `monitoringProviderQuery` field from `Network` * ci: fix linting issues * chore: fix issue with vuex generation * chore: fix vuex module path issue * test: fix broken `cosmosgen` test * fix: correct client root path * test: fix broken integration test * refactor: remove namespace prefix from module paths * ci: fix invalid `Join` call * docs: fixed TS client directory name * test: fix broken unit test * refactor: add link to ts-client to vue app dependencies during scaffold * chore: add indentation to the packages.json file * fix: change Vuex generation to use a relative ts-client link path * chore: change vue app dependency update to return custom errors * fix: Template version and fee fixes * fix: Bump template. Correct proto case types * fix: change TS client generation to always generate third party modules This change is required to re-generate the root module; This module imports and registers custom and third party modules so disabling the 3rd party ones would cause that the pre generated modules wouldn't be imported and registered by the root template. * fix: remove unnecessary env vars * fix: Change generate command from `typescript` to `ts-client` * fix: expose individual clients * fix: add global signingClient * Update ignite/pkg/cosmosgen/templates/root/client.ts.tpl Co-authored-by: Thomas Bruyelle <thomas.bruyelle@gmail.com> * docs: Ts client information * fix: Correct docs markup * fix: add ts syntax to docs code * fix(docs): break up one-liners * fix(docs): Add plugin usage * docs and fixes Co-authored-by: Alex Megalokonomos <alex@clockwork.gr> Co-authored-by: Barrie Byron <barriebyron@gmail.com> Co-authored-by: barriebyron <> Co-authored-by: jeronimoalbi <jeronimo.albi@tendermint.com> Co-authored-by: Thomas Bruyelle <thomas.bruyelle@gmail.com> Co-authored-by: İlker G. Öztürk <ilkergoktugozturk@gmail.com>
Jchicode
pushed a commit
to Jchicode/cli
that referenced
this pull request
Aug 9, 2023
…gnite#2142) (ignite#2143) * feat(frontend): ts-client + pinia (ignite#2142) * Update index.ts.tpl * Update index.ts.tpl * Update package.json.tpl * Update index.ts.tpl * Update package.json.tpl * Update generate_javascript.go * Create index.ts.tpl * Create module.ts.tpl * Create pinia.ts.tpl * Create idnex.ts.tpl * Rename idnex.ts.tpl to index.ts.tpl * Create package.json.tpl * Delete starport/pkg/cosmosgen/templates/vuex directory * Delete starport/pkg/cosmosgen/templates/js directory * Update cosmosgen.go * Update generate_javascript.go * Update template.go * Update generate.go * Update generate.go * Update scaffolder.go * Rename generate_vuex.go to generate_sdk.go * Update config.go * Update generate_javascript.go * Update build.go * Update generate_sdk.go * Update generate_javascript.go * Update generate_javascript.go * 🏗 * adjusted pinia path * 🏗 * n * n * Update starport/pkg/cosmosgen/templates/root/index.ts.tpl Co-authored-by: Alex Megalokonomos <alex@clockwork.gr> * n * plugins * refactored * adjusted ts templates * mod tidy * better syntax * bump @ignt/plugins * tpl header * string formatting * adjusted test out dir * adjusted integration test * adjusted integration test * minors * Update docs/cli/index.md Co-authored-by: Barrie Byron <barriebyron@gmail.com> * Update ignite/cmd/generate_typescript_client.go Co-authored-by: Barrie Byron <barriebyron@gmail.com> * Update docs/kb/frontend.md Co-authored-by: Barrie Byron <barriebyron@gmail.com> * Update build.go * expand on the web app template * grammar fixes for the articles * mono repo URL is changed * add missing article for grammar fix * grammar fix and add more scope to the web app template * feat: Client config typing (ignite#2569) * feat: Client config typing * fix: remove console * wip * wip * fix: remove accidentally committed files * fixed: type issues/code duplication * fix: use new @starport/vuex getter * fix: correct export * fix: changed generate typescript and vuex to match latest changes * fix: change output dir for typescript root templates * fix: remove "module" suffix from typescript module paths It seems that the module folder was replaced by the `module.ts` file during module generation. * fix: replace deprecated `strings.Title()` by a caser * fix: remove unused `monitoringProviderQuery` field from `Network` * ci: fix linting issues * chore: fix issue with vuex generation * chore: fix vuex module path issue * test: fix broken `cosmosgen` test * fix: correct client root path * test: fix broken integration test * refactor: remove namespace prefix from module paths * ci: fix invalid `Join` call * docs: fixed TS client directory name * test: fix broken unit test * refactor: add link to ts-client to vue app dependencies during scaffold * chore: add indentation to the packages.json file * fix: change Vuex generation to use a relative ts-client link path * chore: change vue app dependency update to return custom errors * fix: Template version and fee fixes * fix: Bump template. Correct proto case types * fix: change TS client generation to always generate third party modules This change is required to re-generate the root module; This module imports and registers custom and third party modules so disabling the 3rd party ones would cause that the pre generated modules wouldn't be imported and registered by the root template. * fix: remove unnecessary env vars * fix: Change generate command from `typescript` to `ts-client` * fix: expose individual clients * fix: add global signingClient * Update ignite/pkg/cosmosgen/templates/root/client.ts.tpl Co-authored-by: Thomas Bruyelle <thomas.bruyelle@gmail.com> * docs: Ts client information * fix: Correct docs markup * fix: add ts syntax to docs code * fix(docs): break up one-liners * fix(docs): Add plugin usage * docs and fixes Co-authored-by: Alex Megalokonomos <alex@clockwork.gr> Co-authored-by: Barrie Byron <barriebyron@gmail.com> Co-authored-by: barriebyron <> Co-authored-by: jeronimoalbi <jeronimo.albi@tendermint.com> Co-authored-by: Thomas Bruyelle <thomas.bruyelle@gmail.com> Co-authored-by: İlker G. Öztürk <ilkergoktugozturk@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempt at a better typed plugin system.
Client class is statically configured and exported