Skip to content

feat(cmd/network): implement network profile cmd #2145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 74 commits into from
Jul 27, 2022
Merged

feat(cmd/network): implement network profile cmd #2145

merged 74 commits into from
Jul 27, 2022

Conversation

@Pantani
Copy link
Collaborator

@Pantani Pantani commented Mar 8, 2022 •
edited
Loading

close #2073

Description

Create starport network profile command to show all address info, like vouchers, shares, and descriptions.

How to test

  • Show the global address profile:
ignite network --nightly profile
  • Show the profile based on a campaign ID:
ignite network --nightly profile 36

@Pantani Pantani self-assigned this Mar 8, 2022
Pantani added 12 commits March 9, 2022 00:23
@Pantani Pantani marked this pull request as ready for review March 18, 2022 18:57
@Pantani
Merge remote-tracking branch 'origin/develop' into feat/network-profi…
892e6a8 
…le-cmd

# Conflicts:
#	starport/pkg/goanalysis/goanalysis_test.go
#	starport/services/network/publish.go
@ilgooz ilgooz added this to the T1 milestone Mar 21, 2022
ilgooz
ilgooz reviewed Apr 13, 2022
View reviewed changes
@lumtis lumtis self-assigned this Jul 26, 2022
@lumtis lumtis modified the milestones: T1, Priority Jul 26, 2022
@lumtis lumtis marked this pull request as draft July 26, 2022 12:24
lumtis
lumtis reviewed Jul 26, 2022
View reviewed changes
Copy link
Contributor

@lumtis lumtis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding some comments for my own usage

@lumtis lumtis marked this pull request as ready for review July 26, 2022 13:50
@lumtis
Copy link
Contributor

lumtis commented Jul 26, 2022

The output UX subject to change but I think it's a good base for the command initialization

To test:

ignite chain serve -c config_2.yml -r

Use spnd for campaign and vouchers minting

spnd tx profile create-coordinator --from alice -y --node http://0.0.0.0:26661
spnd tx profile update-coordinator-description --details foo --identity bar --website foo.com --from alice -y --node http://0.0.0.0:26661
spnd tx campaign create-campaign orbit 1000000orbit --from alice -y --node http://0.0.0.0:26661
spnd tx campaign mint-vouchers 1 50000orbit --from alice -y --node http://0.0.0.0:26661
spnd tx campaign redeem-vouchers 1 2000v/1/orbit --from alice -y

ignite account import testnet // import the testnet account from spnd
ignite network  profile 1  --spn-node-address http://0.0.0.0:26661 --from testnet
Address: spn1ezptsm3npn54qx9vvpah4nymre59ykr9exx2ul
CampaignID: 1
Identity: bar
Website: foo.com
Details: foo
Vouchers:
- denom: v/1/orbit
  amount: "48000"
Shares:
- denom: s/orbit
  amount: "2000"

@lumtis
Copy link
Contributor

lumtis commented Jul 26, 2022

Ready for review @ilgooz @tbruyelle @jeronimoalbi @aljo242

aljo242
aljo242 previously approved these changes Jul 26, 2022
View reviewed changes
Copy link
Contributor

@aljo242 aljo242 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@lumtis lumtis self-requested a review July 26, 2022 15:04
@lumtis lumtis requested a review from aljo242 July 26, 2022 15:06
@lumtis
Copy link
Contributor

lumtis commented Jul 26, 2022

lgtm

Just fixed some conflicts

@lumtis lumtis merged commit db73f42 into develop Jul 27, 2022
@lumtis lumtis deleted the feat/network-profile-cmd branch July 27, 2022 08:03
Jchicode pushed a commit to Jchicode/cli that referenced this pull request Aug 9, 2023
@Pantani @lumtis
feat(cmd/network): implement network profile cmd (ignite#2145)
213e13d 
* add the profile command

* add profile queries

* profile command

* add network profile method and print into the cmd

* import sort

* fix unit tests for network publish command

* use profile interface

* fix wrong coord address

* grpc error responses

* update spn and mocks

* fix the profile command and balances

* remove omitted fields

* fix unit tests

* fix unit tests

* apply comment suggestions regarding code style

* handle not found address

* fix imports

* fix imports 2

* some fixes =

* fix cli

* some fixes

* goimport

* fix test

Co-authored-by: ltacker <lucas.bertrand.22@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fadeev fadeev Awaiting requested review from fadeev

@ivanovpetr ivanovpetr Awaiting requested review from ivanovpetr

@jeronimoalbi jeronimoalbi Awaiting requested review from jeronimoalbi

@ilgooz ilgooz Awaiting requested review from ilgooz

@tbruyelle tbruyelle Awaiting requested review from tbruyelle

@lumtis lumtis Awaiting requested review from lumtis

1 more reviewer

@aljo242 aljo242 aljo242 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@Pantani Pantani

@lumtis lumtis

Labels

component:network

Projects

None yet

Milestone

Priority

Development

Successfully merging this pull request may close these issues.

cmd/network: implement profile command

5 participants

@Pantani @ilgooz @lumtis @aljo242