Skip to content

feat: upgrade to ibc v2.0.2 - #1975

Merged
ilgooz merged 5 commits into
release/v0.19.2from
feat/ibc2
Jan 11, 2022
Merged

feat: upgrade to ibc v2.0.2#1975
ilgooz merged 5 commits into
release/v0.19.2from
feat/ibc2

Conversation

@ilgooz

@ilgooz ilgooz commented Jan 7, 2022

Copy link
Copy Markdown
Contributor

No description provided.

@ilgooz ilgooz linked an issue Jan 7, 2022 that may be closed by this pull request
Support to ibc-go v2 #1871
Closed
@ilgooz
ilgooz marked this pull request as draft January 7, 2022 11:37
@ilgooz ilgooz linked an issue Jan 7, 2022 that may be closed by this pull request
Starport doesn't generate the code for Update IBC clients by governance #1813
Closed
@ilgooz ilgooz changed the title feat: upgrade to ibc 2.0.2 feat: upgrade to ibc v2.0.2 Jan 8, 2022
@ilgooz
ilgooz marked this pull request as ready for review January 11, 2022 11:02
@ilgooz

ilgooz commented Jan 11, 2022

Copy link
Copy Markdown
Contributor Author

Please review @lubtd @Pantani

@lubtd

lubtd commented Jan 11, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor

I'm testing it now.

This is not blocking for this PR but I think we will have to remove cosmosibckeeper package and return back to the previous behavior: generating the IBC interfaces on the user chain codebase.
This package forces the user to use the specified version and it can be problematic if they want to update starport dep version for another package without upgrading their IBC
Also this package must be updated if the user want to upgrade IBC, v3 is currently in development

[EDIT]: By "removing", I rather mean moving the current content into the ibc module template

lubtd
lubtd approved these changes Jan 11, 2022
View reviewed changes

@lubtd lubtd left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can run the IBC Hello World tutorial👍

@ilgooz

ilgooz commented Jan 11, 2022

Copy link
Copy Markdown
Contributor Author

I'm testing it now.

This is not blocking for this PR but I think we will have to remove cosmosibckeeper package and return back to the previous behavior: generating the IBC interfaces on the user chain codebase. This package forces the user to use the specified version and it can be problematic if they want to update starport dep version for another package without upgrading their IBC Also this package must be updated if the user want to upgrade IBC, v3 is currently in development

[EDIT]: By "removing", I rather mean moving the current content into the ibc module template

Can you create an issue for this?

@ilgooz
ilgooz merged commit 5165929 into release/v0.19.2 Jan 11, 2022
@ilgooz
ilgooz deleted the feat/ibc2 branch January 11, 2022 12:34
Jchicode pushed a commit to Jchicode/cli that referenced this pull request Aug 9, 2023
@ilgooz
feat: upgrade to ibc v2.0.2 (ignite#1975)
cd929de 
* feat: upgrade to ibc 2.0.2

* templates: upgrade starport version

* ibc: fix gov & other migration

* fix

* fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fadeev fadeev Awaiting requested review from fadeev
@ivanovpetr ivanovpetr Awaiting requested review from ivanovpetr
@Pantani Pantani Awaiting requested review from Pantani
1 more reviewer
@lubtd lubtd lubtd approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Support to ibc-go v2 Starport doesn't generate the code for Update IBC clients by governance

2 participants

@ilgooz @lubtd