feat: plugin system #1959
Closed
feat: plugin system #1959
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The change introduces a plugin system to starport. A plugin is a binary that can communicate with starport using github.com/hashicorp/go-plugin. When starport is executed under a chain configuration, it checks if the config contains plugins. If yes the plugins are fetched, compiled and ran, which will add more commands to the existing ones. Fetching and compilation are cached under .starport/plugins folder. A new command `starport plugin` has been added to manage plugins and make new ones. To give plugins the ability to load the chain, the function `cmd.NewChainWithHomeFlags` is now public.
tbruyelle
requested review from
Pantani,
fadeev,
ilgooz,
ivanovpetr and
lumtis
as code owners
|
rebased in a new PR #2877 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello guys,
here is the PR for the plugin system I wrote for the HackAtom. I don't know exactly how you want to merge it, since it's not a tiny change, so feel free to tell me. We can do a regular review where you ask for changes, or maybe you prefer to merge like it is and improve it later.
The change introduces a plugin system to starport.
A plugin is a binary that can communicate with starport using
github.com/hashicorp/go-plugin. When starport is executed under a chain
configuration, it checks if the config contains plugins. If yes the
plugins are fetched, compiled and ran, which will add more commands to
the existing ones.
Fetching and compilation are cached under .starport/plugins folder.
A new command
starport pluginhas been added to manage plugins and make newones.
To give plugins the ability to load the chain, the function
cmd.NewChainWithHomeFlagsis now public.