Skip to content

feat(cmd/version): provide detailed info #1480

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Aug 20, 2021
Merged

feat(cmd/version): provide detailed info #1480

merged 6 commits into from
Aug 20, 2021

Conversation

@ilgooz
Copy link
Member

@ilgooz ilgooz commented Aug 18, 2021 •
edited by fadeev
Loading 

Starport version:	development
Starport build date:	2021-08-18T14:31:33
Starport source hash:	a2b74e1862524077b836d3670826dfb3f66a3d04
Your os:		linux
Your arch:		amd64
Your go version:	go version go1.16.4 linux/amd64
Your uname -a:		Linux ubuntu 5.8.0-63-generic #71~20.04.1-Ubuntu SMP Thu Jul 15 17:46:08 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Your cwd:		/home/ilker/Documents/code/src/github.com/tendermint/starport
Is on Gitpod:		false
Is in Docker:		false

close #1203

@fadeev
Copy link
Contributor

fadeev commented Aug 18, 2021 •
edited
Loading

Oh, that's neat!

@fadeev
Copy link
Contributor

fadeev commented Aug 18, 2021

@barriebyron any improvements we can make to the text in the first column?

barriebyron
barriebyron reviewed Aug 18, 2021
View reviewed changes
barriebyron
barriebyron previously approved these changes Aug 18, 2021
View reviewed changes
Copy link
Contributor

@barriebyron barriebyron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fadeev a few tiny suggestions: use OS and Go as noted

ilgooz
ilgooz commented Aug 19, 2021
View reviewed changes
fadeev
fadeev approved these changes Aug 19, 2021
View reviewed changes
Copy link
Contributor

@fadeev fadeev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! I'm wondering if we should also include PATH, because you have to use chain's CLI at some point and many forget to set their path.

lumtis
lumtis approved these changes Aug 20, 2021
View reviewed changes
Copy link
Contributor

@lumtis lumtis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ilgooz ilgooz merged commit 12e1e0d into develop Aug 20, 2021
@ilgooz ilgooz deleted the feat/detailed-v branch August 20, 2021 10:24
Jchicode pushed a commit to Jchicode/cli that referenced this pull request Aug 9, 2023
@ilgooz
feat(cmd/version): provide detailed info (ignite#1480)
7e1b85c 
* feat(cmd/version): provide detailed info

* tidy

* fix

* nit

* Update starport/internal/version/version.go
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Pantani Pantani Awaiting requested review from Pantani

3 more reviewers

@fadeev fadeev fadeev approved these changes

@lumtis lumtis lumtis approved these changes

@barriebyron barriebyron barriebyron left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

starport version: output go version, uname and PATH

5 participants

@ilgooz @fadeev @lumtis @barriebyron