Skip to content

Conversation

@ghost
Copy link

@ghost ghost commented Jul 28, 2021

@ghost ghost requested review from Pantani, fadeev, ilgooz and lumtis as code owners July 28, 2021 12:59
@ghost ghost changed the title docs: Add documentation for starport tools completions command docs(cli): Add documentation for starport tools completions command Jul 28, 2021
@fadeev
Copy link
Contributor

fadeev commented Jul 28, 2021

CLI reference is auto-generated, so the changes you made to it will be overwritten. Here are starport tools completions docs already in a PR:

https://github.com/tendermint/starport/blob/f359298f6c58304dc784c84e18f646fe3d18fe83/docs/cli/index.md#starport-tools-completions

Now that I look at the docs, I realize it would be great to remove # symbols, because the markdown parser considers them headings (if you follow the link above, you'll see "To load completions for each session, execute once:" is in HUGE font).

@fadeev fadeev requested a review from barriebyron July 28, 2021 14:12
@alijnmerchant21 alijnmerchant21 self-requested a review July 28, 2021 14:49
barriebyron
barriebyron previously approved these changes Jul 28, 2021
Copy link
Contributor

@barriebyron barriebyron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see my comments and lmk if you have questions
This completions command is cool!

Comment on lines 1327 to 1335
1. Source the completion script in your ~/.bashrc file:
```bash
echo 'source <(starport tools completions bash)' >> ~/.bashrc
```

2. Add the completion script to the /etc/bash_completion.d directory:
```
starport tools completions bash > /etc/bash_completion.d/starport
```
Copy link
Contributor

@barriebyron barriebyron Jul 28, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
1. Source the completion script in your ~/.bashrc file:
```bash
echo 'source <(starport tools completions bash)' >> ~/.bashrc
```
2. Add the completion script to the /etc/bash_completion.d directory:
```
starport tools completions bash > /etc/bash_completion.d/starport
```
1. To enable autocompletion in your current session, source the completion script in your `~/.bashrc` file:
```bash
echo 'source <(starport tools completions bash)' >> ~/.bashrc
```
1. To persist the autocompletion, add the completion script to the `/etc/bash_completion.d` directory:
```
starport tools completions bash > /etc/bash_completion.d/starport
```

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

because these are alternate steps (one or the other) let's use unordered list items (bullets) instead of numbered steps

tip: to "nest" the command under the action step, you can indent. I used 4 spaces here, but in Markdown you can use the tab key

Copy link
Contributor

@barriebyron barriebyron Jul 28, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

of course, now that we've provided clearer steps, we can go back to using ordered steps again.

Check your deploy preview to make sure that the nesting commands don't interfere with the autonumbering. Read all about it on StackOverflow, auto-numbering and code blocks question has been asked and answered many times

@ilgooz ilgooz changed the title docs(cli): Add documentation for starport tools completions command docs(cli): add docs for starport tools completions cmd Jul 29, 2021
Copy link
Contributor

@fadeev fadeev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ilgooz ilgooz merged commit 6a3d556 into ignite:develop Aug 3, 2021
Jchicode pushed a commit to Jchicode/cli that referenced this pull request Aug 9, 2023
* docs: Add documentation for starport tools completions command

* docs: fixing the link

* docs: fix the example

* Updated the documentation in the good place : inside the code

* Reverting mds

Co-authored-by: Denis Fadeev <denis@fadeev.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants