Skip to content

fix(services/chain): don't init accounts from config for SPN chains #1384

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Parent: fix: hotfix/0.17.1
merged 4 commits into from
Jul 20, 2021
Merged

fix(services/chain): don't init accounts from config for SPN chains #1384

merged 4 commits into from
Jul 20, 2021

Conversation

@lumtis
Copy link
Contributor

@lumtis lumtis commented Jul 19, 2021

Prevent initializing accounts from the config when using a chain from Starport Network because in this case we must create our own account

Another fix is to create .starport config directory when initializing networkbuilder config

This fixes currently known issues for Starport Network usage for 0.17.0

@lumtis lumtis requested review from Pantani, fadeev and ilgooz as code owners July 19, 2021 09:41
fadeev
fadeev approved these changes Jul 19, 2021
View reviewed changes
Copy link
Contributor

@fadeev fadeev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for a quick fix! I no longer have this problem.

Still can't start a chain through Gitpod, but it's a separate issue #1385

ilgooz
ilgooz requested changes Jul 19, 2021
View reviewed changes
@ilgooz ilgooz changed the title fix: do not initialize account from config when initializing a Starport Network chain fix(services/chain): don't init accounts from config for SPN chains Jul 19, 2021
lumtis and others added 2 commits July 19, 2021 18:35
@lumtis @ilgooz
Update starport/services/config.go
9dd5163 
Co-authored-by: İlker G. Öztürk <ilkergoktugozturk@gmail.com>
@lumtis
Fixes
08e70bb
@lumtis lumtis requested a review from ilgooz July 19, 2021 16:52
@lumtis lumtis merged commit fe40542 into hotfix/0.17.1 Jul 20, 2021
@lumtis lumtis deleted the fix/spn-0.17.0 branch July 20, 2021 06:26
Jchicode pushed a commit to Jchicode/cli that referenced this pull request Aug 9, 2023
@lumtis
fix(services/chain): don't init accounts from config for SPN chains (i…
7c7c1d1 
…gnite#1384)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Pantani Pantani Pantani approved these changes

@ilgooz ilgooz Awaiting requested review from ilgooz

+1 more reviewer

@fadeev fadeev fadeev approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@lumtis @fadeev @Pantani @ilgooz