Skip to content

Conversation

@lumtis
Copy link
Contributor

@lumtis lumtis commented Jul 16, 2021

The rpc query path used a wrong naming convention for the index name by setting all characters to lowercase.
For example running starport s map foo --index fooBar fails

We set it to lower camel case so it can correctly retrieve the field in the type.

We also add a test to include this case.

@lumtis lumtis requested review from Pantani, fadeev and ilgooz as code owners July 16, 2021 12:11
Copy link
Contributor

@fadeev fadeev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

service Query {
	// Queries a foo by index.
	rpc Foo(QueryGetFooRequest) returns (QueryGetFooResponse) {
		option (google.api.http).get = "/cosmonaut/mars/mars/foo/{fooBar}";
	}
	//...
}

@lumtis lumtis merged commit eac18b4 into develop Jul 16, 2021
@lumtis lumtis deleted the fix/index-case-query branch July 16, 2021 18:00
soniasingla pushed a commit to soniasingla/starport that referenced this pull request Jul 19, 2021
soniasingla pushed a commit to soniasingla/starport that referenced this pull request Jul 20, 2021
soniasingla pushed a commit to soniasingla/starport that referenced this pull request Jul 21, 2021
soniasingla pushed a commit to soniasingla/starport that referenced this pull request Jul 21, 2021
soniasingla pushed a commit to soniasingla/starport that referenced this pull request Jul 21, 2021
soniasingla pushed a commit to soniasingla/starport that referenced this pull request Jul 21, 2021
soniasingla pushed a commit to soniasingla/starport that referenced this pull request Jul 21, 2021
soniasingla pushed a commit to soniasingla/starport that referenced this pull request Jul 21, 2021
soniasingla pushed a commit to soniasingla/starport that referenced this pull request Jul 21, 2021
soniasingla pushed a commit to soniasingla/starport that referenced this pull request Jul 21, 2021
soniasingla pushed a commit to soniasingla/starport that referenced this pull request Jul 21, 2021
Jchicode pushed a commit to Jchicode/cli that referenced this pull request Aug 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants