Skip to content

Conversation

@ilgooz
Copy link
Member

@ilgooz ilgooz commented Jul 12, 2021

whether if 'client' section presents or not in the 'config.yml'.

whether if 'client' section presents or not in the 'config.yml'.
Copy link
Contributor

@fadeev fadeev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix! One suggestion is let's make starport g vuex behave like starport g vuex --rebuild-proto-once, so every time it generates proto for everything. We can drop the flag.

@ilgooz
Copy link
Member Author

ilgooz commented Jul 12, 2021

Any spesific reason to this? Because build and serve command takes the same approach. By removing this flag, one drawback I can think of is, it'll take too much time to complate this command. User also may not care about generating vuex code except their own modules.

@fadeev
Copy link
Contributor

fadeev commented Jul 12, 2021

Consensus is that we generate everything by default with starport g vuex, remove --rebuild-proto-once.

@ilgooz
Copy link
Member Author

ilgooz commented Jul 12, 2021

Handled by 623bab4. 👍

@ilgooz ilgooz requested a review from fadeev July 12, 2021 14:14
@ilgooz ilgooz merged commit 7342975 into develop Jul 13, 2021
@ilgooz ilgooz deleted the fix/codegen-client branch July 13, 2021 06:01
Jchicode pushed a commit to Jchicode/cli that referenced this pull request Aug 9, 2023
* fix(cmd/generate): vuex and openapi cmds should work

whether if 'client' section presents or not in the 'config.yml'.

* fix generate all logic for build and serve

* fix

* generate all
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

starport g vuex doesn't generate code TS generation and build fails if vue dir is deleted

4 participants