Skip to content

chore(templates/ci): do not build arm binaries #1355

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 12, 2021
Merged

chore(templates/ci): do not build arm binaries #1355

merged 1 commit into from
Jul 12, 2021

Conversation

@ilgooz
Copy link
Member

@ilgooz ilgooz commented Jul 12, 2021

Because chains scaffold with Starport uses tendermint/spm and this adds wasm entry to chain's go.sum, therefore chain cannot compile to arm64.

@ilgooz
chore(templates/ci): do not build arm binaries
0b0498f 
because Starport depends on CosmWasm and it doesn't support arm64 atm.
@ilgooz ilgooz requested review from Pantani, fadeev and lumtis as code owners July 12, 2021 08:27
fadeev
fadeev approved these changes Jul 12, 2021
View reviewed changes
Copy link
Contributor

@fadeev fadeev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

lumtis
lumtis approved these changes Jul 12, 2021
View reviewed changes
Copy link
Contributor

@lumtis lumtis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving it as a quick fix

What do you fix of usingspm that doesn't depend on wasm automatically when under arm64?

@ilgooz
Copy link
Member Author

ilgooz commented Jul 12, 2021

Approving it as a quick fix

What do you fix of usingspm that doesn't depend on wasm automatically when under arm64?

I couldn't understand, can ou please elaborate?

@ilgooz ilgooz merged commit 5ed17af into develop Jul 12, 2021
@ilgooz ilgooz deleted the chore/templates branch July 12, 2021 09:38
@lumtis
Copy link
Contributor

lumtis commented Jul 12, 2021

Scaffolded apps import spm under master. If we instead import spm under no-wasm branch there will be no wasm dependency

@ilgooz
Copy link
Member Author

ilgooz commented Jul 12, 2021

This seems like a workaround to me. When users want to add wasm to their chain, they'll still experience with the same error, also, we would need to convert no-wasm to master back in user's go.mod.

@lumtis
Copy link
Contributor

lumtis commented Jul 12, 2021

Yes this is a workaround, in case many users are under arm64 and they want to build an app without wasm

They could modify go.mod manually in the future if they want to import wasm

Jchicode pushed a commit to Jchicode/cli that referenced this pull request Aug 9, 2023
@ilgooz
chore(templates/ci): do not build arm binaries (ignite#1355)
1fe25a1 
because Starport depends on CosmWasm and it doesn't support arm64 atm.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Pantani Pantani Awaiting requested review from Pantani

2 more reviewers

@fadeev fadeev fadeev approved these changes

@lumtis lumtis lumtis approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ilgooz @lumtis @fadeev