improvement(cmd): rename --no-default-module to --no-module #1346
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
soniasingla
requested review from
Pantani,
fadeev,
ilgooz and
lumtis
as code owners
soniasingla
changed the title
|
Hey @soniasingla, can you please update the |
|
@ilgooz thanks i see they are still failing, can you please help me what i am doing wrong here? |
Signed-off-by: Sonia Singla <soniasingla.1812@gmail.com>
|
Re-running the tests fixed it i guess |
lumtis
suggested changes
Jul 7, 2021
There was a problem hiding this comment.
Thanks 👍
Also a quick note that once this PR is merged, we will also need to check if this option is used in the tutorials (which I believe this is the case for interchange tutorial) and we update this change on this PR cosmos/sdk-tutorials#708 that will be merge once Starport 0.17.0 is merge
Co-authored-by: Lucas Bertrand <lucas.bertrand.22@gmail.com>
lumtis
approved these changes
Jul 7, 2021
Pantani
approved these changes
Jul 8, 2021
Jchicode
pushed a commit
to Jchicode/cli
that referenced
this pull request
Aug 9, 2023
) * rename(cmd): rename --no-default-module to --no-module Signed-off-by: Sonia Singla <soniasingla.1812@gmail.com> * Update docs/cli/index.md Co-authored-by: Lucas Bertrand <lucas.bertrand.22@gmail.com> Co-authored-by: Lucas Bertrand <lucas.bertrand.22@gmail.com> Co-authored-by: Denis Fadeev <denis@fadeev.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Sonia Singla soniasingla.1812@gmail.com
Rename --no-default-module to --no-module.
Fixes #1345