Skip to content

Conversation

@soniasingla
Copy link
Contributor

Add a section about Feedback/Issues in the Contributing File 🤗

@soniasingla soniasingla changed the title Add a section about Feedback/Issues in the Contributing File add a section about Feedback/Issues in the Contributing File Jul 6, 2021
@soniasingla soniasingla changed the title add a section about Feedback/Issues in the Contributing File add: section about Feedback/Issues in the Contributing File Jul 6, 2021
@soniasingla soniasingla changed the title add: section about Feedback/Issues in the Contributing File improvement: section about Feedback/Issues in the Contributing File Jul 6, 2021
@fadeev fadeev requested a review from barriebyron July 6, 2021 13:13
@fadeev fadeev changed the title improvement: section about Feedback/Issues in the Contributing File docs: section about Feedback/Issues in the Contributing File Jul 6, 2021
@ilgooz ilgooz changed the title docs: section about Feedback/Issues in the Contributing File docs(contribution): add Feedback/Issues Jul 6, 2021
Copy link
Contributor

@barriebyron barriebyron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@soniasingla thank you for being a part of our team and thanks for this PR. I applied our style standards and made some editorial suggestions... lmk if I can explain or provide more context. Carry on, teammate!

contributing.md Outdated
Thank you for your contribution!

## Opening pull requests
## Feedback / Issues
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
## Feedback / Issues
## Providing feedback

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@soniasingla (it's great to see you here, thanks for this PR!) let's follow the model of using active verbs for headings

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@barriebyron thanks for the great feedback, i have updated the PR, feel free to take a look! 🙌

Copy link
Contributor

@barriebyron barriebyron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We welcome all contributions, and this clarity will help attract them. Thanks @soniasingla

@barriebyron barriebyron self-requested a review July 6, 2021 21:39
Copy link
Member

@ilgooz ilgooz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

## Opening pull requests
## Providing Feedback

* Before you open an issue, do a web search, and check for [existing open and closed GitHub Issues](https://github.com/tendermint/starport/issues) to see if your question has already been asked and answered. If you find a relevant topic, you can comment on that issue.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about navigating users to the Discussions page instead and only use issues for direct bug reports and feature requests?

So, basially, we can convert these three bullets in two, first one saying that "please open a discussion or comment to an existent one for your questions, feedbacks, ideas or use the Discord channel for quick responses."

Second, "please create issues from this link to report a bug or ask for a feature request."

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ilgooz Discussions pages are great alternative but our large user-base/community is over Discord, it supports group voice channels if needed + Screen sharing available in groups!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IIUC, the Discussions page provides a repo-based home... I like @ilgooz's proposal. I had forgotten about using Discussions. @soniasingla wdyt about sending folks from Discord to Discussions? (I seem to remember a conversation about centralizing feedback in GitHub). In this case, @ilgooz suggestions make sense.
I was just reading up on Discussions https://docs.github.com/en/discussions/collaborating-with-your-community-using-discussions/about-discussions
So in this case, it depends on the dev team and how they want to capture the user feedback. Big opportunities!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll think about Discord vs alternatives later. Right now Discord has traction, so we're using that. If people will start using discussions (it's open for them now), we might reconsider.

Copy link
Contributor

@barriebyron barriebyron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sending users from Discord to GitHub discussions and issues might be the direction that @fadeev and team prefer? A larger discussion on workflow can define the content here.

## Opening pull requests
## Providing Feedback

* Before you open an issue, do a web search, and check for [existing open and closed GitHub Issues](https://github.com/tendermint/starport/issues) to see if your question has already been asked and answered. If you find a relevant topic, you can comment on that issue.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IIUC, the Discussions page provides a repo-based home... I like @ilgooz's proposal. I had forgotten about using Discussions. @soniasingla wdyt about sending folks from Discord to Discussions? (I seem to remember a conversation about centralizing feedback in GitHub). In this case, @ilgooz suggestions make sense.
I was just reading up on Discussions https://docs.github.com/en/discussions/collaborating-with-your-community-using-discussions/about-discussions
So in this case, it depends on the dev team and how they want to capture the user feedback. Big opportunities!

@fadeev fadeev merged commit e760acd into ignite:develop Jul 9, 2021
Jchicode pushed a commit to Jchicode/cli that referenced this pull request Aug 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants