feat(cmd/tools): add 'protoc' command and #1301
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and upgrade protoc & add linux arm support. * refactor data dirs for protoc and nodetime pkgs.
|
@Pantani I believe you're using an M1 machine, can you please test this PR for us to see if it works there okay? |
Pantani
previously approved these changes
Jun 26, 2021
lumtis
previously approved these changes
Jun 28, 2021
Co-authored-by: Lucas Bertrand <lucas.bertrand.22@gmail.com>
|
works on M1. Does not seem to work on ARM64 linux. investigating it now |
|
Any chance that we can merge feat/linux-arm64? |
Jchicode
pushed a commit
to Jchicode/cli
that referenced
this pull request
Aug 9, 2023
* feat(cmd/tools): add 'protoc' command and and upgrade protoc & add linux arm support. * refactor data dirs for protoc and nodetime pkgs. * fix * docs * Apply suggestions from code review Co-authored-by: Lucas Bertrand <lucas.bertrand.22@gmail.com> Co-authored-by: Lucas Bertrand <lucas.bertrand.22@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
and upgrade protoc & add linux arm support.
related to #1244.