refactor(template/app): simplify cmd package and use cosmosapp module

[lumtis]

Use the cosmosapp module tendermint/spm#1 to remove non necessary code in cmd and app module of the generated code and make it simpler

Will require tendermint/spm#1 to be merged

[fadeev]

That's awesome! cmd is now so compact 🤩 Shall we rename cosmosapp to chaincmd? Because scaffolding a chain is starport scaffold chain and the package is cmd.

[lumtis]

That's awesome! cmd is now so compact 🤩 Shall we rename cosmosapp to chaincmd? Because scaffolding a chain is starport scaffold chain and the package is cmd.

Yes the name was chosen quickly, it can be changed. Although I don't know for chaincmd. This package basically returns the NewRootCmd method that is the root command for a Cosmos SDK application. Maybe we should make it explicit that this is about the Cosmos SDK?

[fadeev]

Maybe cosmoscmd then 🤔

[lumtis]

Maybe cosmoscmd then 🤔

This one looks good

[lumtis]

The method to import wasm has been modified and so we cannot import wasm with previously scaffolded apps.

Should we keep the legacy way of importing wasm and automatically use it to import wasm on sub 0.16 scaffolded chains or should we just print an error telling the user to downgrade Starport if they want to import wasm?
The thing is that it complexifies the codebase to keep legacy scaffolding features

[fadeev]

should we just print an error telling the user to downgrade Starport if they want to import wasm

I think that's good enough.

[lumtis]

This is ready for review. However, it will require tendermint/spm#1 to be merged first so we can use the correct dependency for spm

[lumtis]

Ready for review :)

[fadeev]

24 lines — sweet! 🙌

[ilgooz]

⚡