feat(pkg/protoanalysis): ignore hidden files #1296
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pantani
force-pushed
the
feat/improve-glob-search
branch
2 times, most recently
from
4cf9dd2 to
4cc9197
Compare
ilgooz
changed the title
Pantani
force-pushed
the
feat/improve-glob-search
branch
from
e738bdf to
1c5a8d6
Compare
ilgooz
requested changes
Jun 28, 2021
Thanks for the help. I'm facing some problems running the integration tests in the mac m1. I need to figure out a way for me can run it locally |
|
Yeah, integration tests are pretty slow. Specially on Rosetta it might be longer. 😄 What works for me is, I only run the test I need on my local and let the CI run the rest of them for me. |
ilgooz
reviewed
Jun 28, 2021
Pantani
force-pushed
the
feat/improve-glob-search
branch
2 times, most recently
from
a089c0d to
485d096
Compare
Pantani
force-pushed
the
feat/improve-glob-search
branch
from
485d096 to
dc35eab
Compare
lumtis
previously approved these changes
Jul 5, 2021
Jchicode
pushed a commit
to Jchicode/cli
that referenced
this pull request
Aug 9, 2023
* improve glob feature and also exclude hidden folders from the path walk * fix the integration tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1249
What does this PR does?
mattn/go-zglobpackage from thego.mod;xospackage methods;How to test?
$ go test github.com/tendermint/starport/starport/pkg/localfs -run Test_glob -v