-
Couldn't load subscription status.
- Fork 570
feat: print modified and created files when scaffolding components #1250
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Awesome, so much better! I was thinking, though, we could follow wdyt? |
Yeah that makes sense. I had |
|
Looking good! One small change, not sure about available colors, but if we can change red to orange, that'd be better. Red is for deletion. I think orange may work good both for light and dark backgrounds. |
|
One more thing. Can you please add an empty line after the command and before the list of paths? Like this: |
Orange may not be available on all terminals, what do you think of magenta? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Magenta's good 🙂 Visible on both dark and light terminals.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔥
| } | ||
|
|
||
| // AppendModifiedFile appends modified files in the source modification that are not already documented | ||
| func (sm *SourceModification) AppendModifiedFiles(modifiedFiles ...string) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| func (sm *SourceModification) AppendModifiedFiles(modifiedFiles ...string) { | |
| func (sm *SourceModification) appendModifiedFiles(modifiedFiles ...string) { |
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Those are actually part of the encapsulated interface, this also allows us to use a separate package for the tests
| } | ||
|
|
||
| // AppendCreatedFiles appends a created files in the source modification that are not already documented | ||
| func (sm *SourceModification) AppendCreatedFiles(createdFiles ...string) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| func (sm *SourceModification) AppendCreatedFiles(createdFiles ...string) { | |
| func (sm *SourceModification) appendCreatedFiles(createdFiles ...string) { |
?


Here is a example of the output:
(With modified files in cyan and created files in green)