feat: support multiple name convention for component and field names #1236
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
When it's ready for review, this should work, right? Or is it too much? 🙈 |
|
Yes. Not in this example because only the message name is parsed |
ilgooz
reviewed
Jun 14, 2021
starport/pkg/field/field_test.go
Outdated
| }, | ||
| }, | ||
| } | ||
| cases.expected[0].Name, _ = multiformatname.NewMultiFormatName("foo") |
There was a problem hiding this comment.
can we refactor this to execute each test over a loop like a table test?
There was a problem hiding this comment.
I made this part a bit cleaner but I'm not sure it it what you meant. This is already a table test but we have a single test that match an expected with an actual array
fadeev
previously approved these changes
Jun 14, 2021
No I can actually add this, we just need to prevent having a number as a prefix |
ilgooz
approved these changes
Jun 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For names (component or field) we will support only alpha characters, hyphen or underscore. This is open for discussion.
Maybe we could prevent using underscore since snake case is never used in the code but we should support hyphen since this is more convient for message and query scaffolding
@fadeev @ilgooz I did the implementation for the
messagescaffold as an example. I will wait for your feedback before moving forward