Skip to content

Conversation

@fadeev
Copy link
Contributor

@fadeev fadeev commented Jun 9, 2021

A good chunk of questions we get on Discord is about appd: command not found. Let's mention this more explicitly in the install doc.

@fadeev fadeev requested review from ilgooz and lumtis as code owners June 9, 2021 03:53
@fadeev fadeev requested a review from barriebyron June 9, 2021 03:54
ilgooz
ilgooz previously approved these changes Jun 9, 2021
@fadeev
Copy link
Contributor Author

fadeev commented Jun 9, 2021

I now know that it's not strictly necessary for Starport to work, but it's still a good practice to set your vars correctly.

Copy link
Contributor

@barriebyron barriebyron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good idea to provide clarity that reduces user friction

@barriebyron barriebyron self-requested a review June 9, 2021 13:11
barriebyron
barriebyron previously approved these changes Jun 9, 2021
@fadeev fadeev dismissed stale reviews from barriebyron and ilgooz via 894fa9d June 9, 2021 13:39
Co-authored-by: Barrie Byron <barrie.byron@tendermint.com>
@barriebyron barriebyron self-requested a review June 9, 2021 14:14
Copy link
Contributor

@barriebyron barriebyron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TIL that synopsis is for the entire topic! thanks @fadeev

@ilgooz ilgooz merged commit 39aef3e into develop Jun 10, 2021
@ilgooz ilgooz deleted the docs-gopath branch June 10, 2021 07:15
Jchicode pushed a commit to Jchicode/cli that referenced this pull request Aug 9, 2023
* docs: install, mention setting go env vars

* Update docs/intro/install.md

Co-authored-by: Barrie Byron <barrie.byron@tendermint.com>

Co-authored-by: Barrie Byron <barrie.byron@tendermint.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants