Skip to content

docs: adding ~/go/bin to $PATH #1198

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 6 commits into from
Closed

docs: adding ~/go/bin to $PATH #1198

wants to merge 6 commits into from

Conversation

@fadeev
Copy link
Contributor

@fadeev fadeev commented May 26, 2021 •
edited
Loading

@barriebyron if you could review this PR, that'd be great 🙏

@fadeev fadeev requested review from dshulyak, ilgooz and lumtis as code owners May 26, 2021 11:15
@fadeev fadeev requested a review from barriebyron May 26, 2021 11:15
@lumtis lumtis changed the title Adding ~/go/bin to $PATH docs: adding ~/go/bin to $PATH May 26, 2021
lumtis
lumtis reviewed May 26, 2021
View reviewed changes
barriebyron
barriebyron reviewed May 26, 2021
View reviewed changes
Copy link
Contributor

@barriebyron barriebyron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some suggestions

fadeev and others added 3 commits May 27, 2021 08:25
@fadeev
Update docs/intro/install.md
3a2384c 
Co-authored-by: Barrie Byron <barrie.byron@tendermint.com>
@fadeev
Update docs/intro/install.md
764f5a2 
Co-authored-by: Barrie Byron <barrie.byron@tendermint.com>
@fadeev
Update docs/intro/install.md
a82d6aa 
Co-authored-by: Barrie Byron <barrie.byron@tendermint.com>
@fadeev
Copy link
Contributor Author

fadeev commented May 27, 2021

Thanks for the edits, @barriebyron. Can't approve my own PR, but this looks good to me.

@fadeev fadeev requested review from barriebyron and lumtis May 27, 2021 03:27
ilgooz
ilgooz reviewed May 27, 2021
View reviewed changes
Copy link
Member

@ilgooz ilgooz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I saw people complaning about this but I still have some doubts about necessity of this change. Starport should not require this to be set for the serve command to work. I need to do some investigations.

barriebyron
barriebyron approved these changes May 27, 2021
View reviewed changes
Copy link
Contributor

@barriebyron barriebyron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM too!

@ilgooz
Copy link
Member

ilgooz commented May 31, 2021

closing in favor of #1215.

@ilgooz ilgooz closed this May 31, 2021
@ilgooz ilgooz deleted the fadeev-patch-2 branch May 31, 2021 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ilgooz ilgooz ilgooz left review comments

@dshulyak dshulyak Awaiting requested review from dshulyak

@lumtis lumtis Awaiting requested review from lumtis

+1 more reviewer

@barriebyron barriebyron barriebyron approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@fadeev @ilgooz @dshulyak @lumtis @barriebyron