feat(templates): unit tests for indexed type #1105
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ilgooz
reviewed
May 7, 2021
| _, err := srv.Create<%= title(TypeName) %>(ctx, &types.MsgCreate<%= title(TypeName) %>{Creator: creator, Index: index}) | ||
| require.NoError(t, err) | ||
|
|
||
| _, err = srv.Update<%= title(TypeName) %>(ctx, tc.request) |
There was a problem hiding this comment.
Shouldn't we also Get and check if it's really updated?
There was a problem hiding this comment.
unfortunately there is nothing to check. Creator can't be updated, and Index is a unique identifier
There was a problem hiding this comment.
Hm. I think, checking with a Get still might be relavent to see that nothing has changed. Also, once users start extending the underlying MsgUpdate type, they'll need to add this right. What do you think?
|
|
||
| _, err := srv.Create<%= title(TypeName) %>(ctx, &types.MsgCreate<%= title(TypeName) %>{Creator: creator, Index: index}) | ||
| require.NoError(t, err) | ||
| _, err = srv.Delete<%= title(TypeName) %>(ctx, tc.request) |
There was a problem hiding this comment.
Shouldn't we also Get and check if it's really deleted?
There was a problem hiding this comment.
was pretty sure that i had the line with Get, lost it somehow :) thanks for catching this
dshulyak
force-pushed
the
feat/indexed-unit-tests
branch
from
3ee8ea3 to
0d14550
Compare
Jchicode
pushed a commit
to Jchicode/cli
that referenced
this pull request
Aug 9, 2023
* feat(templates): unit tests for indexed type * Improve msg server tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related to: #715