Repository navigation
Replace Marshaler with Codec to mimic CosmosSDK patterns. #3641
Description
Describe the bug
I was playing with the Rosetta 1 integration and realized there is a params/encoding.go discrepancy between Ignite and CosmosSDK.
The EncodingConfig struct found in ignite/templates/app/files/app/params/encoding.go.plush should be changed from
type EncodingConfig struct {
InterfaceRegistry types.InterfaceRegistry
Marshaler codec.Codec
TxConfig client.TxConfig
Amino *codec.LegacyAmino
}to
type EncodingConfig struct {
InterfaceRegistry types.InterfaceRegistry
Codec codec.Codec
TxConfig client.TxConfig
Amino *codec.LegacyAmino
}to match the CosmosSDK pattern.
Relates cosmos/cosmos-sdk#17608
What version are you using?
Ignite CLI version: v0.27.1
Ignite CLI build date: 2023-06-13T13:42:09Z
Ignite CLI source hash: 4acd1f1
Ignite CLI config version: v1
Cosmos SDK version: v0.47.3
Your OS: linux
Your arch: amd64
Your Node.js version: v18.16.1
Your go version: go version go1.21.0 linux/amd64
Your uname -a: Linux lemurpro 5.10.192-1-MANJARO #1 SMP PREEMPT Sat Aug 26 20:45:34 UTC 2023 x86_64 GNU/Linux
Your cwd: /home/fmorency
Is on Gitpod: false
Activity
Ehsan-saradar commentedon Sep 18, 2023
Thank you for reporting this issue, @fmorency 🙌
I appreciate you bringing this discrepancy to our attention. I've reviewed the problem, and you're absolutely right. To align with the CosmosSDK pattern, we need to make the change you've suggested in the
EncodingConfigstruct.I'm currently working on a new pull request to address this issue, and I'll keep you updated on its progress. If you have any additional insights or suggestions related to this, please feel free to share them.
Once again, thank you for your contribution to the project! 🚀