fix: Scaffold an IBC module in a non-Starport chain

[fadeev]

Right now starport module create foo --ibc in a chain like Gaia returns:

💬 To enable scaffolding of IBC modules, remove these lines from app/app.go:

ibcRouter := porttypes.NewRouter()
ibcRouter.AddRoute(ibctransfertypes.ModuleName, transferModule)
app.IBCKeeper.SetRouter(ibcRouter)

💬 Then, find the following line:

// this line is used by starport scaffolding # stargate/app/keeperDefinition

💬 Finally, add this block of code below:
ibcRouter := porttypes.NewRouter()
ibcRouter.AddRoute(ibctransfertypes.ModuleName, transferModule)
// this line is used by starport scaffolding # ibc/app/router
app.IBCKeeper.SetRouter(ibcRouter)

app.go doesn't contain the necessary placeholder to generate an IBC module

Instead, it should create x/foo and complain about placeholders.

[lumtis]

What about keeping a warning (modifying it to tell that only the registration of the module failed) and generating the module?

But I actually agree we could get just rid of it. We used this one because the previous release before the release with IBC 0.15 didn't have the necessary placeholder. However, since this has been released several months ago, it may be very unlikely that a blockchain scaffolded with <0.15 will ever use module create --ibc

[fadeev]

Yeah, I would say that generating a module no matter what is the most important thing. If there were no plans to redesign app.go, then we would've just created a tutorial on how to import modules.