feat: add network plugin - #19
Merged
Merged
Conversation
added 4 commits
October 16, 2023 00:42
# Conflicts: # explorer/go.mod # explorer/go.sum # go.work.sum
Pantani
marked this pull request as ready for review
November 8, 2023 12:53
Pantani
requested review from
Ehsan-saradar,
ilgooz,
jeronimoalbi and
julienrbrt
as code owners
November 8, 2023 12:53
ilgooz
previously requested changes
Nov 9, 2023
Contributor
There was a problem hiding this comment.
Thanks for pushing this!
Meanwhile, we should make it clear that this code originates from another repo and should give attributions to the other authors.
We should try finding the best way of giving attributions; at very least we can include them as co-authors by pushing an empty commit. And in the description of the commit we could add more information as/if needed.
Please see the format:
Pantani
marked this pull request as draft
February 1, 2024 19:28
# Conflicts: # explorer/go.mod # explorer/go.sum # go.work.example # integration/go.mod
Pantani
marked this pull request as ready for review
November 1, 2024 00:43
julienrbrt
reviewed
Nov 8, 2024
julienrbrt
previously approved these changes
Mar 25, 2025
julienrbrt
left a comment
julienrbrt
left a comment
Member
There was a problem hiding this comment.
utACK. Can we add this to the app registry?
# Conflicts: # go.work.example
julienrbrt
previously approved these changes
Mar 26, 2025
julienrbrt
approved these changes
Apr 2, 2025
This was referenced Apr 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
move the network app to the apps mono repo
We should add this to the commit before squash: