Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ASCII art / AASVG diagrams #66

Merged
merged 3 commits into from
Mar 4, 2024
Merged

Fix ASCII art / AASVG diagrams #66

merged 3 commits into from
Mar 4, 2024

Conversation

rohanmahy
Copy link
Collaborator

@rohanmahy rohanmahy commented Mar 2, 2024 •
edited
Loading

Send responses as soon as feasible in "Alice Adds Bob" flow

For Bob Adds Cathy flow

  • make ASCII art fit in 72 characters (only done so far for Bob Adds Cathy flow)
  • show fanout to multiple servers and clients closer/tighter in time

Show fanouts to Clients of final commits for Bob leaves room flow

@rohanmahy rohanmahy marked this pull request as ready for review March 4, 2024 16:55
@rohanmahy rohanmahy merged commit cfe2d6d into main Mar 4, 2024
2 checks passed
@rohanmahy rohanmahy deleted the rohan/fix-diagrams branch October 21, 2024 02:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kkohbrok kkohbrok kkohbrok approved these changes

@bifurcation bifurcation Awaiting requested review from bifurcation bifurcation is a code owner

@turt2live turt2live Awaiting requested review from turt2live turt2live is a code owner

@ara4n ara4n Awaiting requested review from ara4n ara4n is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rohanmahy @kkohbrok