Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: don't template inside <script> #8480

Merged
merged 1 commit into from
Jan 29, 2025

Conversation

jennifer-richards
Copy link
Member

Addresses the issue described here #8475 (comment)

(the quoting issues were non-issues, but it's really not a good practice to use Django templating in javascript)

This does not address the issue in that ticket, just the comment.

Copy link

codecov bot commented Jan 29, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.80%. Comparing base (a4eeae5) to head (099df4c).
Report is 10 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8480   +/-   ##
=======================================
  Coverage   88.80%   88.80%           
=======================================
  Files         312      312           
  Lines       40886    40856   -30     
=======================================
- Hits        36308    36284   -24     
+ Misses       4578     4572    -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rjsparks rjsparks merged commit d3bf0a3 into ietf-tools:main Jan 29, 2025
10 checks passed
@jennifer-richards jennifer-richards deleted the no-js-template branch January 30, 2025 00:57
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 3, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants