Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(dev): fix chromedriver crash during tests in devcontainer #3978

Closed
wants to merge 4 commits into from

Conversation

NGPixel
Copy link
Member

@NGPixel NGPixel commented May 16, 2022

Fixes chromedriver crashing during tests by setting 1777 permissions to /dev/shm

@NGPixel NGPixel requested a review from rjsparks May 16, 2022 20:56
@NGPixel NGPixel changed the title chore: fix chromedriver crash during tests chore: fix chromedriver crash during tests in devcontainer May 17, 2022
@NGPixel NGPixel changed the title chore: fix chromedriver crash during tests in devcontainer chore(dev): fix chromedriver crash during tests in devcontainer May 17, 2022
.devcontainer/devcontainer.json Outdated Show resolved Hide resolved
"arcanis.vscode-zipfs",
"dbaeumer.vscode-eslint"
]
"recommendations": []
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This also seems unrelated to this particular problem?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's unrelated but it's to silence some popups when opening vscode. I can make a separate PR if you prefer, but it's quite a tiny change with no impact.

@NGPixel NGPixel requested a review from rjsparks May 18, 2022 19:07
@NGPixel
Copy link
Member Author

NGPixel commented May 19, 2022

Closing in favor of #3981.

@NGPixel NGPixel closed this May 19, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 16, 2022
@NGPixel NGPixel deleted the fix-chromedriver-crash branch June 16, 2022 18:44
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants