Skip to content

Enable external primary data and results #157

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 26 commits into from
Mar 6, 2024
Merged

Enable external primary data and results #157

merged 26 commits into from
Mar 6, 2024

Conversation

jo-bao
Copy link
Contributor

@jo-bao jo-bao commented Jan 17, 2024

Resolves #145

@jo-bao jo-bao self-assigned this Jan 17, 2024
@jo-bao jo-bao mentioned this pull request Jan 17, 2024
Open
@jo-bao jo-bao marked this pull request as ready for review January 30, 2024 10:21
sebastian-peter
sebastian-peter requested changes Feb 22, 2024
View reviewed changes
Copy link
Member

@sebastian-peter sebastian-peter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks quite nice already. Some minor points and questions from my side.

Please remember to look into SonarQube issues that are solvable, and to remove unused imports.

@sebastian-peter sebastian-peter added the enhancement New feature or request label Feb 22, 2024
@sebastian-peter sebastian-peter added this to the 0.5.0 milestone Feb 22, 2024
@jo-bao
Copy link
Contributor Author

jo-bao commented Mar 5, 2024

!test

@jo-bao jo-bao requested a review from sebastian-peter March 5, 2024 10:19
sebastian-peter
sebastian-peter requested changes Mar 5, 2024
View reviewed changes
Copy link
Member

@sebastian-peter sebastian-peter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some more minor comments

@jo-bao jo-bao requested a review from sebastian-peter March 5, 2024 20:01
sebastian-peter
sebastian-peter previously approved these changes Mar 6, 2024
View reviewed changes
Copy link
Member

@sebastian-peter sebastian-peter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe I could still find new points like the one below, but also we want to get through with this... ;)

@sebastian-peter sebastian-peter merged commit 7a281f4 into dev Mar 6, 2024
@sebastian-peter sebastian-peter deleted the jb/#145-externalprimarydata branch March 6, 2024 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sebastian-peter sebastian-peter sebastian-peter approved these changes

Assignees

@jo-bao jo-bao

Labels
enhancement New feature or request
Projects
None yet
Milestone
0.5.0
Development

Successfully merging this pull request may close these issues.

Enable external primary data
2 participants
@jo-bao @sebastian-peter