-
Notifications
You must be signed in to change notification settings - Fork 5
Implement SQL sinks #903
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement SQL sinks #903
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That looks already very good. Very nice work @jo-bao 🚀
I guess this was blocked by the PSU not being released, but can now be unblocked by #1006 |
…ources # Conflicts: # src/test/groovy/edu/ie3/test/common/TimeSeriesTestData.groovy
# Conflicts: # src/main/java/edu/ie3/datamodel/io/naming/DatabaseNamingStrategy.java
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks very good. Some minor things.
Also make sure to take another look at the Sonarqube complaints
src/test/resources/edu/ie3/datamodel/io/sink/_sql/sql_test_data.sql
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks very good. Some minor things.
Also make sure to take another look at the Sonarqube complaints
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just this one open point 🙂
Resolves #762