Fix path at time series mapping #887
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # src/test/groovy/edu/ie3/datamodel/io/csv/BufferedCsvWriterTest.groovy
src/main/java/edu/ie3/datamodel/io/connectors/CsvFileConnector.java
Outdated
Show resolved
Hide resolved
|
Before this regression was introduced, full path and name of the directory path was taken apart and put together again. Seems like this was introduced way back by @johanneshiry to fix some security issue, but my guess is that this is not necessary anymore since we're using java |
danielfeismann
commented
Jan 25, 2024
sebastian-peter
approved these changes
Jan 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #886