-
Notifications
You must be signed in to change notification settings - Fork 7
Adding enhanced error handling for invalid column names in coordinate sources #807
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding enhanced error handling for invalid column names in coordinate sources #807
Conversation
…source-with-invalid-column-names
…source-with-invalid-column-names # Conflicts: # CHANGELOG.md
…source-with-invalid-column-names
…source-with-invalid-column-names
…source-with-invalid-column-names
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please also check out the SonarQube warnings. To solve them, it could be helpful to check out how org.slf4j.Logger can format log messages with supplied objects
src/main/java/edu/ie3/datamodel/io/source/csv/CsvIdCoordinateSource.java
Outdated
Show resolved
Hide resolved
src/main/java/edu/ie3/datamodel/io/factory/timeseries/IdCoordinateFactory.java
Show resolved
Hide resolved
…source-with-invalid-column-names
src/main/java/edu/ie3/datamodel/io/factory/timeseries/IdCoordinateFactory.java
Show resolved
Hide resolved
🛠 Lift Auto-fixSome of the Lift findings in this PR can be automatically fixed. You can download and apply these changes in your local project directory of your branch to review the suggestions before committing.1 # Download the patch
curl https://lift.sonatype.com/api/patch/github.com/ie3-institute/PowerSystemDataModel/807.diff -o lift-autofixes.diff
# Apply the patch with git
git apply lift-autofixes.diff
# Review the changes
git diffWant it all in a single command? Open a terminal in your project's directory and copy and paste the following command: curl https://lift.sonatype.com/api/patch/github.com/ie3-institute/PowerSystemDataModel/807.diff | git applyOnce you're satisfied, commit and push your changes in your project. Footnotes |
…source-with-invalid-column-names # Conflicts: # CHANGELOG.md
|
Ok I just realized we already have a validation in Looking at
So I think there's a way to fix both at the same time: Validate column names once during initialization (and early enough). Opened up a new issue here: #849 With regards to this PR: We could merge it to fix the problem in |
…source-with-invalid-column-names # Conflicts: # src/test/groovy/edu/ie3/datamodel/io/factory/timeseries/CosmoIdCoordinateFactoryTest.groovy # src/test/groovy/edu/ie3/datamodel/io/factory/timeseries/IconIdCoordinateFactoryTest.groovy
…source-with-invalid-column-names
…source-with-invalid-column-names
|
Will be resolved in #926. |
Resolves #670