- 
                Notifications
    You must be signed in to change notification settings 
- Fork 7
Implementing copy method for container classes #749
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
        
          
                src/main/java/edu/ie3/datamodel/models/input/container/InputContainer.java
              
                Outdated
          
            Show resolved
            Hide resolved
        
      | 🛠 Lift Auto-fixSome of the Lift findings in this PR can be automatically fixed. You can download and apply these changes in your local project directory of your branch to review the suggestions before committing.1 # Download the patch
curl https://lift.sonatype.com/api/patch/github.com/ie3-institute/PowerSystemDataModel/749.diff -o lift-autofixes.diff
# Apply the patch with git
git apply lift-autofixes.diff
# Review the changes
git diffWant it all in a single command? Open a terminal in your project's directory and copy and paste the following command: curl https://lift.sonatype.com/api/patch/github.com/ie3-institute/PowerSystemDataModel/749.diff | git applyOnce you're satisfied, commit and push your changes in your project. Footnotes | 
# Conflicts: # CHANGELOG.md
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice Job!! Looks very good already. Just some minor details 🙂
        
          
                src/main/java/edu/ie3/datamodel/models/input/container/InputContainer.java
              
                Outdated
          
            Show resolved
            Hide resolved
        
              
          
                src/main/java/edu/ie3/datamodel/models/input/container/InputContainer.java
              
                Outdated
          
            Show resolved
            Hide resolved
        
              
          
                src/main/java/edu/ie3/datamodel/models/input/container/InputContainer.java
              
                Outdated
          
            Show resolved
            Hide resolved
        
              
          
                src/main/java/edu/ie3/datamodel/models/input/container/JointGridContainer.java
              
                Outdated
          
            Show resolved
            Hide resolved
        
              
          
                src/main/java/edu/ie3/datamodel/models/input/container/SystemParticipants.java
          
            Show resolved
            Hide resolved
        
      …for-containers' into ms/#726-implement-copy-function-for-containers
| !test | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work - Thanks!
Resolves #726