Skip to content

Deprecating unused methods in FileNamingStrategy etc. #724

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Apr 20, 2023
Merged

Deprecating unused methods in FileNamingStrategy etc. #724

merged 8 commits into from
Apr 20, 2023

Conversation

@sebastian-peter
Copy link
Member

@sebastian-peter sebastian-peter commented Jan 19, 2023 •
edited
Loading

Resolves #722

@sebastian-peter sebastian-peter added the code quality Code readability or structure is improved label Jan 19, 2023
@sebastian-peter sebastian-peter self-assigned this Jan 19, 2023
@sebastian-peter sebastian-peter added this to the Version 4.0 milestone Jan 23, 2023
danielfeismann
danielfeismann previously requested changes Feb 10, 2023
View reviewed changes
Copy link
Member

@danielfeismann danielfeismann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beside the sonatype comment this looks fine to me

@jo-bao jo-bao self-requested a review March 28, 2023 13:18
@staudtMarius staudtMarius self-requested a review April 12, 2023 10:57
staudtMarius
staudtMarius approved these changes Apr 18, 2023
View reviewed changes
Copy link
Member

@staudtMarius staudtMarius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@t-ober t-ober requested a review from danielfeismann April 20, 2023 14:05
@t-ober t-ober merged commit c5b3df7 into dev Apr 20, 2023
@t-ober t-ober deleted the sp/#722-deprecate-unused-fns-methods branch April 20, 2023 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sonatype-lift sonatype-lift[bot] sonatype-lift[bot] left review comments

@t-ober t-ober t-ober approved these changes

@staudtMarius staudtMarius staudtMarius approved these changes

@jo-bao jo-bao Awaiting requested review from jo-bao

@danielfeismann danielfeismann Awaiting requested review from danielfeismann

Assignees

@sebastian-peter sebastian-peter

Labels

code quality Code readability or structure is improved

Projects

None yet

Milestone

Version 4.0

Development

Successfully merging this pull request may close these issues.

Deprecate unused methods in FileNamingStrategy and FileHierarchy

5 participants

@sebastian-peter @t-ober @danielfeismann @staudtMarius