Skip to content

Find and add standard asset types #687

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
Jul 5, 2023
Merged

Find and add standard asset types #687

merged 13 commits into from
Jul 5, 2023

Conversation

@staudtMarius
Copy link
Member

Resolves #642

@staudtMarius staudtMarius added the documentation Improvements or additions to documentation label Oct 17, 2022
@staudtMarius staudtMarius self-assigned this Oct 17, 2022
@sonatype-lift
Copy link
Contributor

sonatype-lift bot commented Oct 17, 2022

⚠️ 5 God Classes were detected by Lift in this project. Visit the Lift web console for more details.

@sebastian-peter sebastian-peter mentioned this pull request Jan 10, 2023
Open
sebastian-peter
sebastian-peter previously requested changes Jan 20, 2023
View reviewed changes
Copy link
Member

@sebastian-peter sebastian-peter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A proper review has to happen still, this is just a hint to add a meaningful message about what was added to the changelog :)

@sebastian-peter sebastian-peter added this to the Version 4.0 milestone Jan 23, 2023
danielfeismann
danielfeismann requested changes Jul 3, 2023
View reviewed changes
Copy link
Member

@danielfeismann danielfeismann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, thanks for your work. Just a minor change I would suggest to change in the changelog.

@staudtMarius staudtMarius marked this pull request as ready for review July 4, 2023 11:17
danielfeismann
danielfeismann approved these changes Jul 5, 2023
View reviewed changes
Copy link
Member

@danielfeismann danielfeismann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for improving this!

@danielfeismann danielfeismann merged commit d809936 into dev Jul 5, 2023
@danielfeismann danielfeismann deleted the ms/#642-find-and-add-standard-asset-types branch July 5, 2023 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@danielfeismann danielfeismann danielfeismann approved these changes

@sebastian-peter sebastian-peter sebastian-peter left review comments

Assignees

@staudtMarius staudtMarius

Labels

documentation Improvements or additions to documentation

Projects

None yet

Milestone

Version 4.0

Development

Successfully merging this pull request may close these issues.

Find and add standard asset types

4 participants

@staudtMarius @sebastian-peter @danielfeismann