Skip to content

Conversation

@ckittl
Copy link
Member

@ckittl ckittl commented Mar 8, 2022

Resolves #434

@ckittl ckittl added the bug Something isn't working label Mar 8, 2022
@ckittl ckittl requested a review from a team March 8, 2022 08:17
@ckittl ckittl self-assigned this Mar 8, 2022
johanneshiry
johanneshiry previously approved these changes Mar 8, 2022
Copy link
Member

@johanneshiry johanneshiry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thank you! Approving now but you may take into account my comments though if you want to :)

@sonarqubegithubprchecks

This comment has been minimized.

@codecov
Copy link

codecov bot commented Mar 8, 2022

Codecov Report

Merging #564 (1e739b5) into dev (d67f11c) will decrease coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##                dev     #564      +/-   ##
============================================
- Coverage     77.70%   77.66%   -0.04%     
+ Complexity     2138     2134       -4     
============================================
  Files           271      271              
  Lines          8463     8458       -5     
  Branches        805      804       -1     
============================================
- Hits           6576     6569       -7     
- Misses         1487     1492       +5     
+ Partials        400      397       -3     
Impacted Files Coverage Δ
...atamodel/models/input/system/type/HpTypeInput.java 75.00% <0.00%> (-6.25%) ⬇️
...du/ie3/datamodel/io/source/IdCoordinateSource.java 80.00% <0.00%> (-5.72%) ⬇️
...atamodel/models/input/system/type/BmTypeInput.java 77.77% <0.00%> (-5.56%) ⬇️
...tamodel/models/input/system/type/ChpTypeInput.java 72.00% <0.00%> (-4.00%) ⬇️
...va/edu/ie3/datamodel/io/csv/BufferedCsvWriter.java 65.71% <0.00%> (-2.71%) ⬇️
...atamodel/models/input/system/type/EvTypeInput.java 77.77% <0.00%> (ø)
...tamodel/models/input/system/type/WecTypeInput.java 72.00% <0.00%> (ø)
...del/models/input/system/type/StorageTypeInput.java 71.42% <0.00%> (ø)
...s/input/connector/type/Transformer3WTypeInput.java 73.52% <0.00%> (+1.47%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 657d038...1e739b5. Read the comment docs.

danielfeismann
danielfeismann previously approved these changes Mar 8, 2022
Copy link
Member

@danielfeismann danielfeismann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you :)

@ckittl ckittl dismissed stale reviews from danielfeismann and johanneshiry via 1e739b5 March 8, 2022 14:50
@sonarqubegithubprchecks
Copy link

Passed

Analysis Details

0 Issues

  • Bug0 Bugs
  • Vulnerability0 Vulnerabilities
  • Code Smell0 Code Smells

Coverage and Duplications

  • 100 percent coverage100.00% Coverage (77.00% Estimated after merge)
  • 3 percent duplication0.00% Duplicated Code (0.40% Estimated after merge)

Project ID: edu.ie3:PowerSystemDataModel

View in SonarQube

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Properly write out data given by entity field mapping

5 participants