Skip to content

Conversation

@sebastian-peter
Copy link
Member

@sebastian-peter sebastian-peter commented Mar 1, 2022

M versions are milestone versions (somewhere between snapshot and release candidate), while we should use release versions. Thus, exclude milestone versions.

Also included are probable future versions (2.2-M2) which might come up at some point.

@sebastian-peter sebastian-peter requested a review from a team March 1, 2022 12:44
Copy link
Member

@johanneshiry johanneshiry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@sonarqubegithubprchecks
Copy link

Passed

Analysis Details

0 Issues

  • Bug0 Bugs
  • Vulnerability0 Vulnerabilities
  • Code Smell0 Code Smells

Coverage and Duplications

  • No coverage informationNo coverage information (77.00% Estimated after merge)
  • No duplication informationNo duplication information (0.40% Estimated after merge)

Project ID: edu.ie3:PowerSystemDataModel

View in SonarQube

@codecov
Copy link

codecov bot commented Mar 1, 2022

Codecov Report

Merging #552 (1950da7) into dev (b0cfa27) will increase coverage by 0.15%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##                dev     #552      +/-   ##
============================================
+ Coverage     77.63%   77.79%   +0.15%     
- Complexity     2137     2139       +2     
============================================
  Files           271      271              
  Lines          8505     8457      -48     
  Branches        806      806              
============================================
- Hits           6603     6579      -24     
+ Misses         1496     1482      -14     
+ Partials        406      396      -10     
Impacted Files Coverage Δ
...edu/ie3/datamodel/models/input/AssetTypeInput.java 70.00% <0.00%> (-2.73%) ⬇️
...model/models/input/container/SubGridContainer.java 69.23% <0.00%> (-2.20%) ⬇️
...atamodel/models/input/container/GridContainer.java 52.17% <0.00%> (-2.00%) ⬇️
...tamodel/models/input/thermal/ThermalUnitInput.java 62.50% <0.00%> (-1.50%) ⬇️
...del/models/input/container/JointGridContainer.java 75.00% <0.00%> (-1.20%) ⬇️
...amodel/models/input/graphics/LineGraphicInput.java 83.33% <0.00%> (-0.88%) ⬇️
.../datamodel/models/input/graphics/GraphicInput.java 76.92% <0.00%> (-0.86%) ⬇️
...tamodel/models/input/connector/ConnectorInput.java 64.28% <0.00%> (-0.84%) ⬇️
...edu/ie3/datamodel/models/input/system/EvInput.java 79.41% <0.00%> (-0.59%) ⬇️
...du/ie3/datamodel/models/input/system/WecInput.java 75.60% <0.00%> (-0.59%) ⬇️
... and 38 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ab8b1f1...1950da7. Read the comment docs.

@sebastian-peter sebastian-peter merged commit 08f17a2 into dev Mar 1, 2022
@sebastian-peter sebastian-peter deleted the sp/#000-exclude-groovy4 branch March 1, 2022 12:51
@sebastian-peter sebastian-peter added this to the Version 3.0 milestone Jan 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants