Skip to content

Conversation

@sebastian-peter
Copy link
Member

I anticipated this one going wrong, and it did. Hopefully that's all now.

@sonarqubegithubprchecks

This comment has been minimized.

@codecov
Copy link

codecov bot commented Feb 17, 2022

Codecov Report

Merging #539 (e80799e) into dev (2fbb010) will decrease coverage by 1.28%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##                dev     #539      +/-   ##
============================================
- Coverage     78.93%   77.64%   -1.29%     
- Complexity     2129     2134       +5     
============================================
  Files           265      271       +6     
  Lines          8356     8505     +149     
  Branches        785      806      +21     
============================================
+ Hits           6596     6604       +8     
- Misses         1359     1501     +142     
+ Partials        401      400       -1     
Impacted Files Coverage Δ
.../ie3/datamodel/io/csv/timeseries/ColumnScheme.java 0.00% <0.00%> (-100.00%) ⬇️
.../ie3/datamodel/io/csv/FileNameMetaInformation.java 0.00% <0.00%> (-66.67%) ⬇️
.../edu/ie3/datamodel/io/source/TimeSeriesSource.java 50.00% <0.00%> (-50.00%) ⬇️
...imeseries/IndividualTimeSeriesMetaInformation.java 0.00% <0.00%> (-50.00%) ⬇️
...meseries/LoadProfileTimeSeriesMetaInformation.java 0.00% <0.00%> (-33.34%) ⬇️
...3/datamodel/io/source/csv/CsvTimeSeriesSource.java 73.80% <0.00%> (-20.13%) ⬇️
...3/datamodel/io/source/sql/SqlTimeSeriesSource.java 79.06% <0.00%> (-12.60%) ⬇️
...du/ie3/datamodel/io/naming/FileNamingStrategy.java 81.25% <0.00%> (-11.61%) ⬇️
...del/io/naming/EntityPersistenceNamingStrategy.java 83.58% <0.00%> (-10.54%) ⬇️
...odel/io/source/sql/SqlTimeSeriesMappingSource.java 90.00% <0.00%> (-10.00%) ⬇️
... and 16 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f3b42ee...e80799e. Read the comment docs.

@ckittl
Copy link
Member

ckittl commented Feb 22, 2022

@dependabot rebase 🤦‍♂️

@sonarqubegithubprchecks
Copy link

Passed

Analysis Details

0 Issues

  • Bug0 Bugs
  • Vulnerability0 Vulnerabilities
  • Code Smell0 Code Smells

Coverage and Duplications

  • No coverage informationNo coverage information (76.60% Estimated after merge)
  • No duplication informationNo duplication information (0.40% Estimated after merge)

Project ID: edu.ie3:PowerSystemDataModel

View in SonarQube

@sebastian-peter
Copy link
Member Author

@dependabot rebase 🤦‍♂️

Well I totally get this one 😄

@ckittl ckittl merged commit 4cdc507 into dev Feb 22, 2022
@ckittl ckittl deleted the sp/#000-further-dependabot-update branch February 22, 2022 09:13
@sebastian-peter sebastian-peter added this to the Version 3.0 milestone Jan 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants