Skip to content

Conversation

@sebastian-peter
Copy link
Member

Resolves #535

@sebastian-peter sebastian-peter added the dependencies Pull requests that update a dependency file label Feb 16, 2022
@sebastian-peter sebastian-peter added this to the Version 2.2 milestone Feb 16, 2022
@sebastian-peter sebastian-peter self-assigned this Feb 16, 2022
@sebastian-peter sebastian-peter requested a review from a team February 16, 2022 15:44
@sonarqubegithubprchecks

This comment has been minimized.

@codecov
Copy link

codecov bot commented Feb 16, 2022

Codecov Report

Merging #536 (afb7ca0) into dev (2fbb010) will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##                dev     #536      +/-   ##
============================================
- Coverage     78.93%   78.92%   -0.02%     
+ Complexity     2129     2126       -3     
============================================
  Files           265      265              
  Lines          8356     8356              
  Branches        785      785              
============================================
- Hits           6596     6595       -1     
- Misses         1359     1362       +3     
+ Partials        401      399       -2     
Impacted Files Coverage Δ
.../models/input/thermal/CylindricalStorageInput.java 85.24% <0.00%> (-1.64%) ⬇️
...del/models/input/system/type/StorageTypeInput.java 69.44% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 78ce4cb...afb7ca0. Read the comment docs.

Copy link
Member

@johanneshiry johanneshiry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your work. Please also add Daniel as reviewer in the yml file.

@sonarqubegithubprchecks

This comment has been minimized.

@sonarqubegithubprchecks
Copy link

Passed

Analysis Details

0 Issues

  • Bug0 Bugs
  • Vulnerability0 Vulnerabilities
  • Code Smell0 Code Smells

Coverage and Duplications

  • No coverage informationNo coverage information (78.00% Estimated after merge)
  • No duplication informationNo duplication information (0.20% Estimated after merge)

Project ID: edu.ie3:PowerSystemDataModel

View in SonarQube

Copy link
Member

@johanneshiry johanneshiry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing. Thank you! :)

@johanneshiry johanneshiry merged commit a21d301 into dev Feb 17, 2022
@johanneshiry johanneshiry deleted the sp/#535-update-dependabot-versions branch February 17, 2022 08:25
@sebastian-peter sebastian-peter modified the milestones: Version 2.2, Version 3.0 Feb 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Updating ignored dependency versions

3 participants