Skip to content

Conversation

@t-ober
Copy link
Contributor

@t-ober t-ober commented Feb 1, 2022

Resolves #517

@t-ober t-ober added the enhancement New feature or request label Feb 1, 2022
@t-ober t-ober requested a review from a team February 1, 2022 15:00
@sonarqubegithubprchecks

This comment has been minimized.

@sonarqubegithubprchecks
Copy link

Passed

Analysis Details

0 Issues

  • Bug0 Bugs
  • Vulnerability0 Vulnerabilities
  • Code Smell0 Code Smells

Coverage and Duplications

  • No coverage informationNo coverage information (78.20% Estimated after merge)
  • 3 percent duplication0.00% Duplicated Code (0.20% Estimated after merge)

Project ID: edu.ie3:PowerSystemDataModel

View in SonarQube

@codecov
Copy link

codecov bot commented Feb 1, 2022

Codecov Report

Merging #520 (eec2bc6) into dev (4132f45) will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##                dev     #520      +/-   ##
============================================
+ Coverage     78.93%   78.94%   +0.01%     
- Complexity     2129     2131       +2     
============================================
  Files           265      265              
  Lines          8356     8356              
  Branches        785      785              
============================================
+ Hits           6596     6597       +1     
+ Misses         1361     1356       -5     
- Partials        399      403       +4     
Impacted Files Coverage Δ
...atamodel/models/input/system/type/EvTypeInput.java 73.68% <0.00%> (ø)
...tamodel/models/input/system/type/WecTypeInput.java 69.23% <0.00%> (ø)
...atamodel/models/input/system/type/BmTypeInput.java 78.94% <0.00%> (+5.26%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ddb1ba1...eec2bc6. Read the comment docs.

@t-ober t-ober merged commit 9da870c into dev Feb 2, 2022
@t-ober t-ober deleted the to/#517-fix-code-smells branch February 2, 2022 07:31
@sebastian-peter sebastian-peter added this to the Version 3.0 milestone Jan 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix code smells found by lift

3 participants