-
Couldn't load subscription status.
- Fork 7
To/#508 fix code smells #509
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thank you! 🚀
If CI passes, feel free to merge :)
This comment has been minimized.
This comment has been minimized.
Analysis Details1 IssueCoverage and DuplicationsProject ID: edu.ie3:PowerSystemDataModel |
Codecov Report
@@ Coverage Diff @@
## dev #509 +/- ##
============================================
- Coverage 78.93% 78.92% -0.02%
+ Complexity 2130 2125 -5
============================================
Files 265 265
Lines 8361 8356 -5
Branches 786 785 -1
============================================
- Hits 6600 6595 -5
- Misses 1358 1364 +6
+ Partials 403 397 -6
Continue to review full report at Codecov.
|
| */ | ||
| @Override | ||
| @Deprecated | ||
| @Deprecated(since = ("Deprecated since 2.1.0. See Javadocs for more information.")) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
UnnecessaryParentheses: These grouping parentheses are unnecessary; it is unlikely the code will be misinterpreted without them (details)
(at-me in a reply with help or ignore)
| */ | ||
| @Override | ||
| @Deprecated | ||
| @Deprecated(since=("Deprecated since 2.1.0. See Javadocs for more information.")) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
UnnecessaryParentheses: These grouping parentheses are unnecessary; it is unlikely the code will be misinterpreted without them (details)
(at-me in a reply with help or ignore)
Resolves #508