Skip to content

Conversation

@t-ober
Copy link
Contributor

@t-ober t-ober commented Jan 20, 2022

Resolves #508

@t-ober t-ober requested a review from a team January 20, 2022 16:14
Copy link
Member

@johanneshiry johanneshiry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you! 🚀

If CI passes, feel free to merge :)

@sonarqubegithubprchecks

This comment has been minimized.

@sonarqubegithubprchecks
Copy link

Passed

Analysis Details

1 Issue

  • Bug0 Bugs
  • Vulnerability0 Vulnerabilities
  • Code Smell1 Code Smell

Coverage and Duplications

  • 100 percent coverage100.00% Coverage (78.00% Estimated after merge)
  • 3 percent duplication0.00% Duplicated Code (0.20% Estimated after merge)

Project ID: edu.ie3:PowerSystemDataModel

View in SonarQube

@codecov
Copy link

codecov bot commented Jan 20, 2022

Codecov Report

Merging #509 (68cc7ab) into dev (8493071) will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##                dev     #509      +/-   ##
============================================
- Coverage     78.93%   78.92%   -0.02%     
+ Complexity     2130     2125       -5     
============================================
  Files           265      265              
  Lines          8361     8356       -5     
  Branches        786      785       -1     
============================================
- Hits           6600     6595       -5     
- Misses         1358     1364       +6     
+ Partials        403      397       -6     
Impacted Files Coverage Δ
...tamodel/models/input/system/type/ChpTypeInput.java 69.23% <0.00%> (-3.85%) ⬇️
...n/java/edu/ie3/datamodel/utils/ContainerUtils.java 81.20% <0.00%> (-0.23%) ⬇️
...atamodel/models/input/system/type/EvTypeInput.java 73.68% <0.00%> (ø)
...tamodel/models/input/system/type/WecTypeInput.java 69.23% <0.00%> (ø)
...del/models/input/system/type/StorageTypeInput.java 69.44% <0.00%> (ø)
...atamodel/models/input/system/type/HpTypeInput.java 76.47% <0.00%> (+5.88%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 330e28f...68cc7ab. Read the comment docs.

@t-ober t-ober merged commit e1948ad into dev Jan 20, 2022
@t-ober t-ober deleted the to/#508-fix-code-smells branch January 20, 2022 16:24
*/
@Override
@Deprecated
@Deprecated(since = ("Deprecated since 2.1.0. See Javadocs for more information."))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UnnecessaryParentheses: These grouping parentheses are unnecessary; it is unlikely the code will be misinterpreted without them (details)
(at-me in a reply with help or ignore)

*/
@Override
@Deprecated
@Deprecated(since=("Deprecated since 2.1.0. See Javadocs for more information."))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UnnecessaryParentheses: These grouping parentheses are unnecessary; it is unlikely the code will be misinterpreted without them (details)
(at-me in a reply with help or ignore)

@sebastian-peter sebastian-peter added this to the Version 3.0 milestone Jan 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix code smells from recent merge

4 participants