Skip to content

convert line length to Standardunits.LINE_LENGTH #413

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 25, 2021
Merged

convert line length to Standardunits.LINE_LENGTH #413

merged 2 commits into from
Aug 25, 2021

Conversation

@t-ober
Copy link
Contributor

@t-ober t-ober commented Aug 25, 2021 •
edited
Loading

Closes #412

@t-ober t-ober requested a review from johanneshiry August 25, 2021 08:30
@t-ober t-ober added the bug Something isn't working label Aug 25, 2021
@t-ober t-ober requested a review from ckittl August 25, 2021 08:30
johanneshiry
johanneshiry suggested changes Aug 25, 2021
View reviewed changes
Copy link
Member

@johanneshiry johanneshiry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No description provided. Please add a description or a comment to the corresponding issue (e.g. "Closes #XXXX") accordingly

@codecov
Copy link

codecov bot commented Aug 25, 2021 •
edited
Loading

Codecov Report

Merging #413 (f922492) into dev (98fc18b) will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##                dev     #413      +/-   ##
============================================
- Coverage     78.94%   78.92%   -0.02%     
+ Complexity     2107     2106       -1     
============================================
  Files           259      259              
  Lines          8253     8253              
  Branches        775      775              
============================================
- Hits           6515     6514       -1     
  Misses         1346     1346              
- Partials        392      393       +1
Impacted Files Coverage Δ
...datamodel/io/naming/DefaultDirectoryHierarchy.java 93.10% <0.00%> (-0.87%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 08ffc65...f922492. Read the comment docs.

@t-ober t-ober requested a review from johanneshiry August 25, 2021 12:11
@johanneshiry johanneshiry merged commit 357394e into dev Aug 25, 2021
@johanneshiry johanneshiry deleted the to/#412-line-length-to-standardunits branch August 25, 2021 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ckittl ckittl Awaiting requested review from ckittl

1 more reviewer

@johanneshiry johanneshiry johanneshiry approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Line length of LineInput Constructor does not convert line length to StandardUnits.LINE_LENGTH

3 participants

@t-ober @johanneshiry