Skip to content

address #264 correctly #322

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Apr 9, 2021
Merged

Conversation

johanneshiry
Copy link
Member

Finally resolves #264

@johanneshiry johanneshiry added the bug Something isn't working label Apr 7, 2021
@johanneshiry johanneshiry added this to the Version 2.0 milestone Apr 7, 2021
@johanneshiry johanneshiry requested a review from ckittl April 7, 2021 11:51
@johanneshiry johanneshiry self-assigned this Apr 7, 2021
@codecov
Copy link

codecov bot commented Apr 7, 2021

Codecov Report

Merging #322 (fb3f060) into dev (58c87e2) will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##                dev     #322   +/-   ##
=========================================
  Coverage     78.04%   78.05%           
+ Complexity     2103     2102    -1     
=========================================
  Files           257      257           
  Lines          8399     8401    +2     
  Branches        814      815    +1     
=========================================
+ Hits           6555     6557    +2     
  Misses         1441     1441           
  Partials        403      403           
Impacted Files Coverage Δ Complexity Δ
...edu/ie3/datamodel/io/source/csv/CsvDataSource.java 90.22% <0.00%> (+0.11%) 54.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1ff902a...fb3f060. Read the comment docs.

ckittl
ckittl previously approved these changes Apr 9, 2021
Copy link
Member

@ckittl ckittl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, for letting the last PR regarding #264 pass. I simply got your issue wrong... 😞

Despite of possibly accepting my pedantic, feel free to close and merge.

Co-authored-by: Chris Kittl <44838605+ckittl@users.noreply.github.com>
ckittl
ckittl previously approved these changes Apr 9, 2021
@johanneshiry johanneshiry merged commit 22d91c6 into dev Apr 9, 2021
@johanneshiry johanneshiry deleted the jh/#264-fix-NPE-in-CsvDataSource branch April 9, 2021 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NullPointerException when no operator headline in .csv file is present
2 participants