Updated DataSourceClassDiagram.puml and DataSourceClassDiagram_draft.puml #312
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…emented interface from DataSourceClassDiagram_draft
Codecov Report
@@ Coverage Diff @@
## dev #312 +/- ##
=========================================
Coverage 77.98% 77.98%
Complexity 1951 1951
=========================================
Files 249 249
Lines 7936 7936
Branches 749 749
=========================================
Hits 6189 6189
Misses 1321 1321
Partials 426 426 Continue to review full report at Codecov.
|
|
I think the draft one isn't of too big importance, because it somehow is a idea for the future. Then we can easily adapt it to the current state. |
ckittl
approved these changes
Mar 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #286. Changes done:
DataSourceClassDiagram.pumlDataSourceClassDiagram_draft.pumlI am not sure whether some interfaces which are being talked about in
DataSourceClassDiagram_draft.pumlare already implemented or not because there are several differences in the names of these interfaces in the two files, for example, I am not sure ifWeatherDataSourceandWeatherSourceare referring to the same thing or not.